-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CSS triggerPropertyValueCompletion setting #149
Implement CSS triggerPropertyValueCompletion setting #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some cleanup of the long tesetCompletionFor function later. For now just add another parameter for the setting to expected
for testing your changes.
@octref Could you review again? I created tests and made some small changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, small nitpick. Thanks!
@octref Let me know if I can create a PR in VS Code to add package.json
package.nls.json
|
Something like "By default, VS Code triggers property value completion after selecting a CSS property. Use this setting to disable this behavior." would do. |
When this PR will be merged, I will create a setting inside
css-language-features
which is invscode
repo.Related to: microsoft/vscode#68495