Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the values of editor settings that we track #12635

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Aug 26, 2024

A follow up to the previous logging change. Let me know if this is overkill. We don't have code that tracks changes for editor settings, so this initial proposal will always log the values.

This may or may not be desirable so I'm soliciting feedback about the path forward. Should we:

  1. Always log these values?
  2. Always log a subset of these values? (e.g. if we don't think we care about some of them)
  3. Write code to check if the values are not the default before logging them? The right solution here might involve some refactoring in the settings tracker class or moving the code to settings.ts (more work).

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Aug 27, 2024

Logging all the VS Code settings, including the unmodified ones, seem fine to me -- it's already a subset of all the VS Code settings. You could file a GitHub issue to track showing only the modified ones if you want (it doesn't seem that important to me).

@bobbrow bobbrow merged commit 994e7b9 into main Aug 28, 2024
6 checks passed
@bobbrow bobbrow deleted the bobbrow/logEditorSettings branch August 28, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants