Update cppbuild task behavior for args and command fields to match VS Code's shell task type
#12026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
changed the title
cppbuild task behavior for 'args' and 'command' fields to match VS Code's shell task typecppbuild task behavior for args and command fields to match VS Code's shell task type
sean-mcmanus
approved these changes
Feb 27, 2024
bobbrow
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #12001
Reworks handling of the
argsandcommandfield to exactly match the behavior documented for VS Codeshelltasks, as documented here: https://code.visualstudio.com/docs/editor/tasksA major portion of this was copied directly from VS Code: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts
This replicates variable bugs and incomplete functionality in VS Code, such as
escapequoting on Windows/cmd, which it does not appear to attempt. I believe we'll want to redirect any usability issues that repro withshelltasks, directly to VS Code, and maintain our support as identical to theirs.