Fix broken editor.wordBasedSuggestions setting. #11773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
approved these changes
Dec 12, 2023
|
Do we need to update our VS Code min version dependency for this? |
Yeah, seems like we may need to -- I asked a question at microsoft/vscode#197690 . |
|
@bobbrow This causes the bug to be fixed with the latest VS Code but it breaks older VS Codes -- it seems like it's preferable to prioritize making the latest VS Code work correctly until VS Code can fix the regression? |
Yes, I would agree. The old setting value doesn't work in latest. Let's check it in. |
bobbrow
approved these changes
Jan 17, 2024
sean-mcmanus
changed the title
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting configuration is "broken" with the latest VS Code 1.85.0.
Without the fix:
