Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addTrustedCompiler. #10961

Merged
merged 7 commits into from
May 19, 2023
Merged

Fix addTrustedCompiler. #10961

merged 7 commits into from
May 19, 2023

Conversation

sean-mcmanus
Copy link
Contributor

TypeScript changes related to #10943 .

  • The previous code wasn't sending the added trusted compilers to the native side so the known compilers wasn't getting updated.
  • The previous code was sending trusted compilers as an array when that isn't needed.

@sean-mcmanus sean-mcmanus requested a review from a team May 17, 2023 01:37
fearthecowboy
fearthecowboy previously approved these changes May 17, 2023
View reviewed changes
@bobbrow bobbrow linked an issue May 17, 2023 that may be closed by this pull request
"Select IntelliSense Configuration" and Run&Debug button do not offer user-specified compilerPath #10943
Closed
@bobbrow bobbrow removed a link to an issue May 17, 2023
"Select IntelliSense Configuration" and Run&Debug button do not offer user-specified compilerPath #10943
Closed
Colengms
Colengms requested changes May 17, 2023
View reviewed changes
Extension/src/LanguageServer/client.ts Outdated Show resolved Hide resolved
@sean-mcmanus sean-mcmanus marked this pull request as ready for review May 18, 2023 23:54
michelleangela
michelleangela previously approved these changes May 19, 2023
View reviewed changes
Colengms
Colengms previously approved these changes May 19, 2023
View reviewed changes
michelleangela
michelleangela previously approved these changes May 19, 2023
View reviewed changes
@sean-mcmanus sean-mcmanus dismissed stale reviews from michelleangela and Colengms via 8ada9de May 19, 2023 18:02
@sean-mcmanus sean-mcmanus merged commit c22d13a into main May 19, 2023
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixAddTrustedCompiler branch May 19, 2023 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michelleangela michelleangela michelleangela approved these changes

@fearthecowboy fearthecowboy fearthecowboy left review comments

@Colengms Colengms Colengms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sean-mcmanus @fearthecowboy @michelleangela @Colengms