Always add workspaceFolder to browse.path if unset
#10916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
approved these changes
May 3, 2023
Colengms
changed the title
workspaceFolder to browse.path is unsetworkspaceFolder to browse.path if unset
sean-mcmanus
approved these changes
May 4, 2023
michelleangela
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #10914
Ensures
workspaceFolderis added to thebrowse.path, even ifincludePathis not set.It's possible for the user to indicate they don't want their
workspaceFolderparsed, by providing their ownbrowse.pathvalue and not specifying the workspace folder in it.