remote attach: use absolute /bin/sh path on Linux #10765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardenGnaw
reviewed
Mar 31, 2023
sean-mcmanus
requested changes
Apr 3, 2023
When using machinectl as a transport to connect the debugger to a nspawn container, we need to pass full paths when running commands, as that's what machinectl expects. Use /bin/sh when running on Linux. This allows connecting VSCode to nspawn containers. https://www.freedesktop.org/software/systemd/man/machinectl.html https://www.freedesktop.org/software/systemd/man/systemd-nspawn.html
WardenGnaw
approved these changes
Apr 3, 2023
sean-mcmanus
approved these changes
Apr 4, 2023
|
@WardenGnaw @sean-mcmanus thanks for the reviews and approvals - who can I ask about clicking the merge button? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using machinectl as a transport to connect the debugger to a nspawn container, we need to pass full paths when running commands, as that's what machinectl expects. Use /bin/sh when running on Linux. This allows connecting VSCode to nspawn containers.
https://www.freedesktop.org/software/systemd/man/machinectl.html https://www.freedesktop.org/software/systemd/man/systemd-nspawn.html