-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Configure Intellisense" Status Bar Item #10690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still pops up the "You do not have IntelliSense configured" 2nd prompt if it gets configured from the Status Bar item (or some other means) -- is that fixable? I was thinking maybe it could check if the setting had gotten set already. Or maybe we could file another issue to track that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status UI doesn't disappear after I set the C_Cpp.default.compilerPath in the settings.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to fix the bug #10691 before adding this status bar UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobbrow @browntarik Should the status bar item open the original info prompt instead of the Select Compiler dropdown if a potential compiler is found? That would make it easier to click the Yes button.
This is an interesting idea. @AlexandraKemperMS what do you think? |
I like this idea, but I think for a lot of users the quickpick will be much more noticeable - around half of users dismiss the notification, and that's the ones who respond at all/see it in the first place. Also, the compiler we would normally recommend in the notification would be at the top of the list in the quickpick, so also the first thing to select. |
Ok, that makes sense to me. |
Bob says this can be fixed afterwards. |
Work item reference (GitHub issue link, etc.): #10685
Problem:
• Users are having trouble configuring a compiler for IntelliSense even with our notification on startup
Fix:
• Add a persistent status bar item that will let the user know they do not have a compiler selected. This status bar item will call the Select Default Compiler command
How tested:
• Manual Testing
Implementation Summary:
• Added compilerStatusBarItem to UI along with corresponding member variables which are set in client.ts