This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
Now we provide a reason of why start-up failed #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflicts |
roblourens
reviewed
Mar 23, 2018
| // Chrome started to navigate to the user's requested url | ||
| this.events.emit(ChromeDebugSession.FinishedStartingUpEventName); | ||
| this.events.emit(ChromeDebugSession.FinishedStartingUpEventName, { requestedContentWasDetected: true } as FinishedStartingUpEventArguments); |
There was a problem hiding this comment.
I use the cast to make sure I'm sending the right properties.
If I don't put the cast, the object is of type any, and anything is considered valid.
If I put the cast, then the compiler will fail if I don't put the valid properties here.
There was a problem hiding this comment.
I was thinking 'emit' was typed here
digeff
force-pushed
the
startup_fail_reason
branch
from
3331046 to
a2a5c18
Compare
|
Check CI? |
|
Please do this for node2 also |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are asked to go to an unreachable url, we'll add that information to the start-up timings telemetry.
This PR requires this -core PR: microsoft/vscode-chrome-debug-core#316