Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Commit

Permalink
3.1.7
Browse files Browse the repository at this point in the history
  • Loading branch information
roblourens committed Jul 31, 2017
1 parent fb71e28 commit 94bc1e2
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 3.1.7
* Support new "Loaded scripts" view in VS Code 1.15 - [Microsoft/vscode-chrome-debug-core#118](https://github.com/microsoft/vscode-chrome-debug-core/issues/118)
* Fix hover on variables defined in async functions using TS transpilation - [Microsoft/vscode#31469](https://github.com/Microsoft/vscode/issues/31469)
* Decrease extension package size

## 3.1.6
* Support `console.dir` and other missing `console` APIs - [Microsoft/vscode#29602](https://github.com/Microsoft/vscode/issues/29602)
* Resolve longer `pathMapping` mappings before resolving shorter ones - [#444](https://github.com/microsoft/vscode-chrome-debug/issues/444)
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "debugger-for-chrome",
"displayName": "Debugger for Chrome",
"version": "3.1.6",
"version": "3.1.7",
"icon": "images/icon.png",
"description": "Debug your JavaScript code in the Chrome browser, or any other target that supports the Chrome Debugger protocol.",
"author": {
Expand All @@ -21,7 +21,7 @@
],
"license": "SEE LICENSE IN LICENSE.txt",
"dependencies": {
"vscode-chrome-debug-core": "3.16.0",
"vscode-chrome-debug-core": "3.16.4",
"vscode-debugadapter": "^1.22.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions src/chromeDebugAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,11 @@ export class ChromeDebugAdapter extends CoreDebugAdapter {
super.onResumed();
}

public disconnect(): void {
public disconnect(args: DebugProtocol.DisconnectArguments): void {
const hadTerminated = this._hasTerminated;

// Disconnect before killing Chrome, because running "taskkill" when it's paused sometimes doesn't kill it
super.disconnect();
super.disconnect(args);

if (this._chromeProc && !hadTerminated) {
// Only kill Chrome if the 'disconnect' originated from vscode. If we previously terminated
Expand Down

0 comments on commit 94bc1e2

Please sign in to comment.