This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
We adapt to the latest version of Node.js which uses file:/// and we don't send sourceRef for files that exist #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We adapt to the latest version of Node.js which uses file:/// and we don't send sourceRef for files that exist
In Node v11 it adds file:/// to script urls. That made existAsync return false, we sent the sourceRef to VS which assumes that the file is not on disk because of that, and causes breakpoints to not be shown properly.
We use the canonicalized version which removes file:/// to fix that issue