Fix #268 - Fix .* pattern in skipFiles glob

microsoft · Jan 21, 2018 · 0b79e7c · 0b79e7c
1 parent 5e2ce71
commit 0b79e7c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/utils.ts b/src/utils.ts
@@ -465,8 +465,8 @@ export function pathToRegex(aPath: string, caseSensitive: boolean): string {
 
 export function pathGlobToBlackboxedRegex(glob: string): string {
     return escapeRegexSpecialChars(glob, '*')
+        .replace(/([^*]|^)\*([^*]|$)/g, '$1.*$2') // * -> .*
         .replace(/\*\*(\\\/|\\\\)?/g, '(.*\\\/)?') // **/ -> (.*\/)?
-        .replace(/([^\.]|^)\*/g, '$1.*') // * -> .*
 
         // Just to simplify
         .replace(/\.\*\\\/\.\*/g, '.*') // .*\/.* -> .*

diff --git a/test/utils.test.ts b/test/utils.test.ts
@@ -352,6 +352,10 @@ suite('Utils', () => {
             // but not something that ends in foo.js
             assert(!r.test('barfoo.js'));
         });
+
+        test('.* in glob', () => {
+            testPathGlobToBlackboxedRegex('foo.*.bar', 'foo\\..*\\.bar');
+        });
     });
 
     suite('makeRegexNotMatchPath/makeRegexMatchPath', () => {