azure: Add wizard steps to list/create UserAssignedIdentities and execute role definitions
#1757
Conversation
|
I should probably revisit exposing the scope since it contains the subscription id of the resource as well. Probably can just split by |
|
|
||
| export async function createAuthorizationManagementClient(context: InternalAzExtClientContext): Promise<AuthorizationManagementClient> { | ||
| if (parseClientContext(context).isCustomCloud) { | ||
| return <AuthorizationManagementClient><unknown>createAzureClient(context, (await import('@azure/arm-authorization-profile-2020-09-01-hybrid')).AuthorizationManagementClient); |
There was a problem hiding this comment.
Oh nice, so the hybrid profile version was made to support custom clouds?
There was a problem hiding this comment.
Is there a downside to just always using the one that supports custom clouds?
There was a problem hiding this comment.
Discussed offline, but the api-versions for custom clouds aren't kept up to date as quickly as standard Azure SDKs.
Time is running out |
New message looks like this: |
|
|
||
| export async function createAuthorizationManagementClient(context: InternalAzExtClientContext): Promise<AuthorizationManagementClient> { | ||
| if (parseClientContext(context).isCustomCloud) { | ||
| return <AuthorizationManagementClient><unknown>createAzureClient(context, (await import('@azure/arm-authorization-profile-2020-09-01-hybrid')).AuthorizationManagementClient); |
There was a problem hiding this comment.
Is there a downside to just always using the one that supports custom clouds?
See an example of this being used here: https://github.com/microsoft/vscode-azurefunctions/pull/4213/files
This adds
managedIdentityto theResourceWizardContextsince managed identity will be included in a lot of our resources.The
UserAssignedIdentitysteps are for listing and creating new identities. Right now, it will always default to creating it in the resource group. That reminds me, I need to test what happens if I pick an existing resource group that already has an MI in it. I'm not even sure what behavior should be-- create a new one with a suffix or use the existing one?The
RoleAssignmentStepshould work for both system and user assigned identities. Because the scope will be created during the wizard, you need to pass a function that returns the property that you want since the context will be updated by the time the function is called. Execute priority is also 900 because in most cases, it should always be the last thing to execute.