Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WinDBG extension: AsyncDebugTools #236

Merged
merged 3 commits into from
Apr 12, 2018
Merged

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Apr 12, 2018

Publishes the !dumpasync WinDBG extension

@AArnott AArnott self-assigned this Apr 12, 2018
@AArnott AArnott added this to the v15.8 milestone Apr 12, 2018
@AArnott AArnott force-pushed the dev/andarno/windbgExtension branch 2 times, most recently from 74c58e9 to b7c59ee Compare April 12, 2018 18:37
@AArnott AArnott force-pushed the dev/andarno/windbgExtension branch from 7edaa70 to 04a0d41 Compare April 12, 2018 19:20
@AArnott AArnott requested a review from lifengl April 12, 2018 19:26
@AArnott
Copy link
Member Author

AArnott commented Apr 12, 2018

@lifengl: can you please review? We can replace the code with the C# version when we have it working.

@lifengl
Copy link
Member

lifengl commented Apr 12, 2018

looks good to me. The cpsnfe command is not used or maintained for a long time, so not sure whether it still works. The other two commands are working.

@AArnott
Copy link
Member Author

AArnott commented Apr 12, 2018

Thanks. I tried !dumpversions and that wasn't working for me. So ya, there may be some more fixups to do or commands to remove if we don't want to support them in the future.

@AArnott AArnott merged commit 1495c2e into master Apr 12, 2018
@AArnott AArnott deleted the dev/andarno/windbgExtension branch April 12, 2018 20:07
@lifengl
Copy link
Member

lifengl commented Apr 12, 2018

That should work. But that command is very specific to CPS to dump the version dictionary in the dataflow, and less useful for others. When the managed version works, I think about adding something to help to dump some immutable structures. It is very time consuming to walk the binary tree to find something.

@AArnott
Copy link
Member Author

AArnott commented Apr 12, 2018

OK, then I think we should remove !dumpversions from this repo, and leave that to the CpsDbg.dll binary.

AArnott added a commit to AArnott/vs-threading that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants