Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JoinableTaskInternals.IsMainThreadBlockedByAnyJoinableTask method #1067

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add JoinableTaskInternals.IsMainThreadBlockedByAnyJoinableTask method #1067

merged 2 commits into from
Jul 20, 2022

Conversation

jialongcheng
Copy link
Contributor

We still need a way to check whether the main thread is blocked by any joinableTask inside WaitSynchronouslyCore. This reintroduces previous commit 553c404

The change also creates a VS helper class and declare the new API as internal use only.

@AArnott AArnott force-pushed the dev/jialongcheng/MainThreadBlockedByJoinableTask branch 2 times, most recently from f5b8f42 to bf93947 Compare July 20, 2022 00:28
@AArnott AArnott changed the base branch from main to v17.3 July 20, 2022 00:28
@AArnott AArnott added this to the v17.3 milestone Jul 20, 2022
@AArnott AArnott changed the title Dev/jialongcheng/main thread blocked by joinable task Add JoinableTaskInternals.IsMainThreadBlockedByAnyJoinableTask method Jul 20, 2022
@AArnott AArnott changed the base branch from v17.3 to main July 20, 2022 00:29
@AArnott AArnott modified the milestones: v17.3, v17.4 Jul 20, 2022
jialongcheng and others added 2 commits July 19, 2022 18:30
@jialongcheng @AArnott
Add JoinableTaskInternals.IsMainThreadBlockedByAnyJoinableTask method
ea43cb9 
This re-expose a property on whether JoinableTaskContext has any JoinableTask blocking calls on the main thread

This is based on a revert of commit b0cf150, reversing
changes made to 0847b84.
@AArnott
Hide the internal API more, and move the tests
c1654d4
@AArnott AArnott force-pushed the dev/jialongcheng/MainThreadBlockedByJoinableTask branch from bf93947 to c1654d4 Compare July 20, 2022 00:31
@AArnott AArnott enabled auto-merge July 20, 2022 00:32
@AArnott AArnott merged commit b27c8ee into microsoft:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v17.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jialongcheng @AArnott