-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grpc] Upgrade to gRPC-1.26.0 #9363
Conversation
From UWP build log:
The documentation shows:
So I think the function |
[snip]
I disabled the GCE checks on UWP, just like they were on the previous version. I really doubt folks will be deploying UWP applications to GCE instances, and the only downside (that I know of, at least at this time) is some more complicated authentication configuration if you are trying to access Google services via gRPC. |
@jozefizso, would you like to help review this PR? |
@PhoebeHui definitely not. You threw away my contribution and I should work on someone else code? Why? |
@dan-shaw that is fine. Once you do, I will see if a simple rebase works, but if not I might have to close this PR and start over (no biggie if that is the case). In the future, would you like me to preserve existing patches? What if they stop working? Should I delete them or replace them? |
@coryan Thanks - that would be great. The only conflict should be the UWP patch. If patches stop working (but are still relevant), update the respective patch files. In either case, if a patch file is unsuccessfully applied, it should fail in the CI. |
I just rebased this PR, in detail, this is why I changed the patches:
I installed |
@dan-shaw PTAL |
LGTM |
This updates gRPC to 1.26.0. I removed a number of patches that are no longer needed,
and updated existing patches to match the new line numbers.
This fixes #8453
I do not believe this patch breaks or fixes any particular triplets, but I am less certain about the UWP triplets.