Corrade: Drop vs2017 workaround when building HEAD for vs2019 #7566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s2019 Otherwise building HEAD is broken. Also add a warning about current Corrade release not supporting vs2019, suggesting to use HEAD instead.
|
Looks good to me, thank you -- if this works for you, then I guess it would do for others as well. Could you add the other change from #7537 (fixing the repeated |
|
True, I missed this one. This done now. |
frabert
pushed a commit
to libdmusic/vcpkg
that referenced
this pull request
Aug 7, 2019
…oft#7566) * Corrade: Make sure to drop vs2017 workaround when building HEAD for vs2019 Otherwise building HEAD is broken. Also add a warning about current Corrade release not supporting vs2019, suggesting to use HEAD instead. * [corrade] this option name is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEAD now supports vs2019 and the workaround is not needed anymore.
Build has been tested with both vs2017 and vs2019 x64-windows, using both latest release and HEAD.
Also add a warning about current Corrade release not supporting vs2019, suggesting to use HEAD instead.
This is another attempt at #7537.
@mosra