-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[asyncplusplus] Update asyncplusplus to v1.2 #41420
[asyncplusplus] Update asyncplusplus to v1.2 #41420
Conversation
@JonLiu1993 , this is the new PR to merge, sorry for the mess. |
This PR makes the port lie about its version. |
We can't update ports in this fashion. If the port claims to give you version 1.1, then it must provide version 1.1. We can't simply give them a newer version.
What are these changes, exactly? Is there a particular issue you are facing or is this a "nice to have"? |
How to otherwise update ports that did not have a new release, yet were updated to support the new standard?
Version 1.1 of this library is using I have opened an issue on the library's GitHub to create a new release but the owner does not seem active there. |
In that case, please download the fix directly from upstream and apply as a patch. |
Thanks for the reply. If I cannot update the port in the vcpkg repo with this PR, I’ll simply keep the change in my fork of it. Thanks.
From: Javier Matos Denizac
Sent: Wednesday, October 9, 2024 9:51 PM
To: microsoft/vcpkg ***@***.***>
Cc: Jan Wilczek ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/vcpkg] [asyncplusplus ] Update asyncplusplus to master (PR #41420)
We can't update ports in this fashion. If the port claims to give you version 1.1, then it must provide version 1.1. We can't simply give them a newer version.
How to otherwise update ports that did not have a new release, yet were updated to support the new standard?
What are these changes, exactly? Is there a particular issue you are facing or is this a "nice to have"?
Version 1.1 of this library is using std::result_of which was completely removed (not just deprecated) in C++ 20 in favor of std::invoke_result. So the library at the 1.1 release does not compile with C++ 20 (which my project is using). This was updated on master but without a new release. The library continues to support older standards though.
I have opened an issue on the library's GitHub to create a new release but the owner does not seem active there.
In that case, please download the fix directly from upstream and apply as a patch.
—
Reply to this email directly, view it on GitHub <#41420 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF6TC4ZWVH27RVEKDXYRBX3Z2WCLHAVCNFSM6AAAAABPRXTSU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGMYTAOJTGM> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I want to clarify. I'm not saying we can't fix the issue. I'm stating that we can't change the ref to point to head or some arbitrary commit. I'm inviting you to download the commit that applies the fix you are seeking and applying that as a patch. |
Thanks @JavierMatosD ; the maintainer of the library has tagged a new release so I can update the port properly 🙂 |
This PR updates the port for
Amanieu/asyncplusplus
without changing the official version number.The port is now based on commit
4159da7
from the upstream repository, which introduces an important update allowing the library to be used with C++ 20 and 23 without breaking the compatibility with previous C++ standards (std::aligned_storage
andstd::invoke_result
, for example).Since this is not an official version bump, I've incremented the
port-version
to reflect the change../vcpkg x-add-version --all
and committing the result.