Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libtracepoint/libtracepoint-control] disable building tools #39025

Merged
merged 3 commits into from
Jun 6, 2024
Merged

[libtracepoint/libtracepoint-control] disable building tools #39025

merged 3 commits into from
Jun 6, 2024

Conversation

idigdoug
Copy link
Contributor

@idigdoug idigdoug commented May 29, 2024 •
edited
Loading

libtracepoint should disable building tools/samples/examples. Some of this was already disabled but the settings need to be updated. Noticed because libtracepoint tool build fails if building in an environment that does not default to C++17 or later.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

idigdoug added 3 commits May 29, 2024 16:33
@idigdoug
libtracepoint - don't build tools
d92351c 
libtracepoint should be disabling tools by default. Noticed this because
in some build environments, the tools fail to build.
@idigdoug
Version updates for libtracepoint 1.3.3 port 1
35cc1aa
@idigdoug
Add missed baseline.json
9799f1b
@Cheney-W Cheney-W changed the title Tracepoint no tools [libtracepoint/libtracepoint-control] disable building tools May 30, 2024
@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 30, 2024
@Cheney-W Cheney-W marked this pull request as draft May 30, 2024 08:45
@idigdoug idigdoug marked this pull request as ready for review May 30, 2024 22:24
@Cheney-W Cheney-W marked this pull request as draft May 31, 2024 10:24
@idigdoug idigdoug marked this pull request as ready for review May 31, 2024 18:10
@idigdoug idigdoug requested a review from Cheney-W June 3, 2024 23:56
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 4, 2024
@vicroms vicroms merged commit 557b1bb into microsoft:master Jun 6, 2024
17 checks passed
@idigdoug idigdoug deleted the tracepoint-no-tools branch June 20, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idigdoug @dg0yt @Cheney-W @vicroms