Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wolfssl] Build wolfssl with HAVE_EX_DATA and NO_WOLFSSL_STUB to enable async use and coexistence with openssl without link error #38994

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

ycdev1
Copy link
Contributor

@ycdev1 ycdev1 commented May 28, 2024

Async applications using wolfssl need to associate extra data (application context) with the ssl session and context. This is used in verification callback.
NO_WOLFSSL_STUB is needed to prevent a link time error resulting from duplicate symbols when linking to both wolfssl and openssl at the same time

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label May 29, 2024
@ycdev1
Copy link
Contributor Author

ycdev1 commented May 29, 2024

Can I see the details of build failure for android and osx ?

@MonicaLiu0311
Copy link
Contributor

Please get failure logs here on x64-osx.

-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - broken
CMake Error at /Users/vcpkg/Data/downloads/tools/cmake-3.29.2-osx/cmake-3.29.2-macos-universal/CMake.app/Contents/share/cmake-3.29/Modules/CMakeTestCCompiler.cmake:67 (message):
  The C compiler

    "/Library/Developer/CommandLineTools/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/Users/vcpkg/Data/b/wolfssl/x64-osx-rel/CMakeFiles/CMakeScratch/TryCompile-PwvBMm'
    
    Run Build Command(s): /usr/local/bin/ninja -v cmTC_dfc59

@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented May 30, 2024

The specific steps to view the CI error log are as follows, taking arm64-android as an example:

  1. Click "details" to enter
    image

  2. Click the link for "errors/warnings"
    image

  3. Click the "triplets" you want to view
    image

  4. Download the log file
    image
    image

  5. View the stdout-triplets.log log to continue
    image

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft May 30, 2024 02:40
ports/wolfssl/portfile.cmake Outdated Show resolved Hide resolved
missing space before -DHAVE_EX_DATA to avoid having something like '-arch x86_64-DHAVE_EX_DATA' in the command line!

Co-authored-by: Kai Pastor <dg0yt@darc.de>
@ycdev1
Copy link
Contributor Author

ycdev1 commented May 30, 2024

thanks for the review! I didn't think without this space it will end up with '-arch x86_64-DHAVE_EX_DATA' on the command line as it worked on windows and linux

@ycdev1 ycdev1 marked this pull request as ready for review May 30, 2024 17:51
@MonicaLiu0311
Copy link
Contributor

At present, the version information of your commit is inconsistent with your local one:

##[error]Found the following errors:
##[error]versions/w-/wolfssl.json(2,): error : while parsing versions for wolfssl from version/w-/wolfssl.json
5.7.0#1 is declared with 4c06acb4358f2d96b464a6ea1466e4b27d42bbda, but the local port has a different SHA 60802b6ec5e1284242e1b501a1eed34033bbdc35.

Please run ./vcpkg x-add-version testPort [--overwrite-version] before each push:

  1. For any file modification under the ports/testPort/ folder, please commit after modification
  2. Run ./vcpkg x-add-version testPort to generate a series of version according to your commit info (Add --overwrite-version when generating other than the first time)
  3. Commit verison information again
  4. Push together

--overwrite-version
After the first modification, please run ./vcpkg x-add-version testPort to generate the corresponding json; for subsequent modifications of the same version, please use ./vcpkg x-add-version testPort --overwrite-version to update git-tree.

maintainer guide#versioning.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jun 3, 2024
@vicroms vicroms merged commit 6e31ee3 into microsoft:master Jun 6, 2024
17 checks passed
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Nov 19, 2024
7 tasks
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Feb 7, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants