Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdf5] Update version to 1.14.4.3 #38911

Merged
merged 16 commits into from
Jun 3, 2024
Merged

[hdf5] Update version to 1.14.4.3 #38911

merged 16 commits into from
Jun 3, 2024

Conversation

hyoklee
Copy link
Contributor

@hyoklee hyoklee commented May 23, 2024

No description provided.

@hyoklee
Copy link
Contributor Author

hyoklee commented May 23, 2024 •
edited
Loading

@microsoft-github-policy-service agree company="The HDF Group"

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 24, 2024
@JonLiu1993
Copy link
Member

Please run command ./vcpkg x-add-version hdf5 and commit agagin.

@JonLiu1993 JonLiu1993 marked this pull request as draft May 24, 2024 05:43
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@hyoklee hyoklee marked this pull request as ready for review May 24, 2024 23:50
JonLiu1993
JonLiu1993 previously approved these changes May 28, 2024
View reviewed changes
@JonLiu1993
Copy link
Member

@hyoklee, thanks for your PR, when I tested the feature with command "./vcpkg install hdf5[*]:x64-windows", I get this error, please take a look:

CMake Error at config/cmake/HDFUseFortran.cmake:16 (enable_language):
  No CMAKE_Fortran_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "FC" or the CMake cache entry CMAKE_Fortran_COMPILER to the full
  path to the compiler, or to the compiler name if it is in the PATH.
Call Stack (most recent call first):
  config/cmake/HDF5UseFortran.cmake:17 (include)
  CMakeLists.txt:1076 (include)

@Neumann-A
Copy link
Contributor

@JonLiu1993 remove the fortran feature from your install command..... you don't have a fortran compiler setup

@hyoklee
Copy link
Contributor Author

hyoklee commented May 28, 2024

@JonLiu1993 thanks for testing all options. I could duplicate your error.
FYI, the same error occurs in the current hdf5 vcpkg port 1.14.2.
Do you want me to remove fortran option completely as suggested by @Neumann-A
or give a warning to user via message?

@Neumann-A
Copy link
Contributor

Do you want me to remove fortran option completely as suggested by @Neumann-A

No don't remove it.I just that that @JonLiu1993 test should remove it from the install command. It works if you have a Fortran compiler setup....

@JonLiu1993
Copy link
Member

Feature [cpp,map,parallel,szip,tools,utils,zlib] tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 31, 2024
@vicroms vicroms merged commit 7f35e3e into microsoft:master Jun 3, 2024
17 checks passed
@hyoklee
Copy link
Contributor Author

hyoklee commented Jun 3, 2024

Thank you, @vicroms, for merging this PR!

This was referenced Jun 5, 2024
Merged
Closed
vicroms pushed a commit that referenced this pull request Jun 6, 2024
@LilyWangLL
[vcpkg baseline][many ports] Change fail list in ci.baseline.txt (#39135
b772578 
)

```
PASSING, REMOVE FROM FAIL LIST: hdf5:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: hdf5:x64-android
PASSING, REMOVE FROM FAIL LIST: hdf5:arm64-android
PASSING, REMOVE FROM FAIL LIST: hdf5:arm64-windows
```
Passing on
https://dev.azure.com/vcpkg/public/_build/results?buildId=103642&view=results.
The installation of `hdf5:arm64-windows` and androids triplet were fixed
by PR #38911.

Other ports are dependent on `hdf5`, so add them fail status of androids
triplet in `ci.baseline.txt`.

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~~SHA512s are updated for each updated download.~~
- [ ] ~~The "supports" clause reflects platforms that may be fixed by
this new version.~~
- [ ] ~~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~~
- [ ] ~~Any patches that are no longer applied are deleted from the
port's directory.~~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

---------

Co-authored-by: Lily Wang <v-lilywang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyoklee @JonLiu1993 @Neumann-A @vicroms