[projectm-eval] Add new port #38550
Merged
[projectm-eval] Add new port #38550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaquewithaq
force-pushed
the
add-port-projectm-eval
branch
from
a1e50b0 to
b718624
Compare
dg0yt
reviewed
May 4, 2024
Blaquewithaq
force-pushed
the
add-port-projectm-eval
branch
from
b718624 to
1fc020c
Compare
LilyWangLL
added
the
category:new-port
|
Is there anything else I need to do on this PR or is it good to go? |
You should mark it as "ready for review" to get an official reviewer. |
|
Usage test passed on |
LilyWangLL
reviewed
May 7, 2024
LilyWangLL
approved these changes
May 7, 2024
data-queue
approved these changes
May 8, 2024
yurybura
pushed a commit
to yurybura/vcpkg
that referenced
this pull request
May 8, 2024
This new overlay-port introduces the ProjectM Expression Evaluation Library, which is a prerequisite for building the ProjectM Library. This addition is to complement the PR microsoft#38535, which aims to address the external dependency concern. ProjectM: https://github.com/projectM-visualizer/projectm ProjectM Eval: https://github.com/projectM-visualizer/projectm-eval --- - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines. - [x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all `find_package` calls are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or disabled with [CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html). - [x] The versioning scheme in `vcpkg.json` matches what upstream says. - [x] The license declaration in `vcpkg.json` matches what upstream says. - [x] The installed as the "copyright" file matches what upstream says. - [x] The source code of the component installed comes from an authoritative source. - [x] The generated "usage text" is accurate. See [adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md) for context. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is in the new port's versions file. - [x] Only one version is added to each modified port's versions file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new overlay-port introduces the ProjectM Expression Evaluation Library, which is a prerequisite for building the ProjectM Library. This addition is to complement the PR #38535, which aims to address the external dependency concern.
ProjectM: https://github.com/projectM-visualizer/projectm
ProjectM Eval: https://github.com/projectM-visualizer/projectm-eval
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.