Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host deps for android image #37902

Closed
wants to merge 1 commit into from
Closed

Host deps for android image #37902

wants to merge 1 commit into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 1, 2024

Background: #37196

@BillyONeal BillyONeal added the depends:vm-update PR contains changes to the VM provisioning scripts label Apr 1, 2024
@BillyONeal
Copy link
Member

I'm tagging this with vm-update because we tend to update the docker containers at the same time as the VMs and I want to make sure when we do that for April we handle this at the latest.

However, we should be able to handle docker container changes more frequently.

@BillyONeal
Copy link
Member

What are your thoughts on using docker for more things as a means of making our build environment(s) easier for folks to replicate?

My only hesitation is the recent backlash docker got over licensing mess...

@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 2, 2024

I can't say much about docker.
But I think that the same scripting should be used to host linux builds and android builds, so that even linux ABI hashes match for host dependencies.
And since my last provisioning PR, I wonder if it is really time to move all those portfile messages about "system packages" to a script function, to display vendor specific install instructions, to select msys packages and to verify/generate CI image package lists.

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Apr 11, 2024
@BillyONeal
Merge commit 'a52e9dde0dc85c07fea3a1f667a116bf485e488f' ( microsoft#3…
1420c22 
…7902 )  into patch-tuesday-april-2024
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Apr 12, 2024
@BillyONeal BillyONeal mentioned this pull request Apr 12, 2024
Merged
BillyONeal added a commit that referenced this pull request Apr 26, 2024
@BillyONeal @dg0yt
Patch Tuesday for April 2024 (#38166)
90a5b03 
Changes this month:

* Adopt
[delegated-sas](https://learn.microsoft.com/en-us/rest/api/storageservices/create-user-delegation-sas)
tokens to allow us to shut off the storage account keys, thanks to
@ryanerdmann for the help
* Visual Studio 2022 17.8.9, hopefully resolves CVE-2024-26190,
CVE-2024-21392 . (These don't matter to us but they cause the
Microsoft-internal tool 'Service 360' to yell at us)
* #37902
* #37903

---------

Co-authored-by: Kai Pastor <dg0yt@darc.de>
@BillyONeal BillyONeal closed this Apr 26, 2024
@BillyONeal
Copy link
Member

Already merged, thank you!

@dg0yt dg0yt deleted the provisioning branch April 29, 2024 05:35
@dg0yt
Copy link
Contributor Author

dg0yt commented May 24, 2024

Already using it, #37196 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
depends:vm-update PR contains changes to the VM provisioning scripts info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @BillyONeal @MonicaLiu0311