Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libqtrest] Add new port #34455

Merged
merged 7 commits into from
Oct 17, 2023
Merged

[libqtrest] Add new port #34455

merged 7 commits into from
Oct 17, 2023

Conversation

kafeg
Copy link
Contributor

@kafeg kafeg commented Oct 12, 2023

Here the new port for the https://github.com/qtrest/qtrest library.

@@ -0,0 +1,22 @@
{
"name": "qtrest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably have a more distinct name since it is not related to qt* modules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... is for e.g. libqtrest ok? =)

Copy link
Contributor

@Osyotr Osyotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add "default-features": false for both qt5-base and qt5-declarative just in case.

@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 13, 2023
@LilyWangLL LilyWangLL changed the title QtRest: new port [libqtrest] Add new port Oct 17, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 17, 2023
@JavierMatosD JavierMatosD merged commit 034298f into microsoft:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants