[axcioma] New port (C++11 CORBA implementation TAOX11) #31203

bold84 · 2023-05-01T19:16:28Z

Neumann-A · 2023-05-01T19:20:52Z

ports/axcioma/portfile.cmake

+
+
+vcpkg_execute_required_process(
+  COMMAND ${BRIX11} bootstrap taox11


AXCIOMA is the default target for bootstrapping. The bootstrap command will clone all dependent git repositories to their expected location. This can be done by executing

yeah... no that is not going to work. You have to do it manually so that asset caching can take effect.

@Neumann-A Thanks for your comment!
This is a port I wrote three years ago. I have to get into it again. 😅

AXCIOMA is the default target for bootstrapping. The bootstrap command will clone all dependent git repositories to their expected location. This can be done by executing

yeah... no that is not going to work. You have to do it manually so that asset caching can take effect.

Can you have another look? Thanks!

ports/axcioma/CONTROL

Neumann-A · 2023-05-03T08:18:26Z

ports/axcioma/portfile.cmake

+if(VCPKG_TARGET_IS_WINDOWS)
+  set(LIB_RELEASE_SUFFIX .lib)
+  set(LIB_DEBUG_SUFFIX d.lib)
+  set(DLL_RELEASE_SUFFIX .dll)
+  set(DLL_DEBUG_SUFFIX d.dll)
+  set(LIB_PREFIX)
+  if (VCPKG_LIBRARY_LINKAGE STREQUAL static)
+    set(DLL_DECORATOR s)
+  endif()
+elseif(VCPKG_TARGET_IS_LINUX)
+  set(DLL_DECORATOR)
+  set(LIB_RELEASE_SUFFIX .a)
+  set(LIB_DEBUG_SUFFIX .a)
+  set(DLL_RELEASE_SUFFIX .so)
+  set(DLL_DEBUG_SUFFIX .so)
+  set(LIB_PREFIX lib)
+elseif(VCPKG_TARGET_IS_OSX)
+  set(DLL_DECORATOR)
+  set(LIB_RELEASE_SUFFIX .a)
+  set(LIB_DEBUG_SUFFIX .a)
+  set(DLL_RELEASE_SUFFIX .dylib)
+  set(DLL_DEBUG_SUFFIX .dylib)
+  set(LIB_PREFIX lib)
+endif()


Use:

vcpkg/scripts/cmake/vcpkg_common_definitions.cmake

Lines 75 to 110 in 6d69bba

if(VCPKG_TARGET_IS_MINGW)

set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".a")

set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX ".dll.a")

set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".dll")

set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "lib")

set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "lib")

set(VCPKG_TARGET_IMPORT_LIBRARY_PREFIX "lib")

set(VCPKG_FIND_LIBRARY_SUFFIXES ".dll" ".dll.a" ".a" ".lib")

set(VCPKG_FIND_LIBRARY_PREFIXES "lib" "")

elseif(VCPKG_TARGET_IS_WINDOWS)

set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".lib")

set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX ".lib")

set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".dll")

set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX ".lib")

set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "")

set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "")

set(VCPKG_TARGET_IMPORT_LIBRARY_PREFIX "")

set(VCPKG_FIND_LIBRARY_SUFFIXES ".lib" ".dll") #This is a slight modification to CMakes value which does not include ".dll".

set(VCPKG_FIND_LIBRARY_PREFIXES "" "lib") #This is a slight modification to CMakes value which does not include "lib".

elseif(VCPKG_TARGET_IS_OSX)

set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".a")

set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX "")

set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".dylib")

set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "lib")

set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "lib")

set(VCPKG_FIND_LIBRARY_SUFFIXES ".tbd" ".dylib" ".so" ".a")

set(VCPKG_FIND_LIBRARY_PREFIXES "lib" "")

else()

set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".a")

set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX "")

set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".so")

set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "lib")

set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "lib")

set(VCPKG_FIND_LIBRARY_SUFFIXES ".so" ".a")

set(VCPKG_FIND_LIBRARY_PREFIXES "lib" "")

endif()

Neumann-A · 2023-05-03T08:19:38Z

scripts/ci.baseline.txt

+axcioma:x64-windows-static-md=fail
+axcioma:arm64-windows=fail
+axcioma:x64-uwp=fail
+axcioma:arm-uwp=fail
+axcioma:x64-android=fail
+axcioma:arm64-android=fail
+axcioma:arm-neon-android=fail
+axcioma:x64-osx=fail


you don't need CI baseline since you use supports

Improved portfile

…axcioma

…e's copy command.

bold84 · 2023-05-04T21:47:22Z

Because this port implicitly builds ACE, which axcioma heavily depends on, it conflicts with the ACE port. I don't think it's right to add "skip" to ci.baseline.txt without first trying to combine axcioma and ace ports.

Maybe it would be possible with a specific feature that builds the existing ace port in a way so it can be used for axcioma.
@jwillemsen is likely the best person who can answer this question.

jwillemsen · 2023-05-05T11:46:30Z

ACE needs to be compiled with versioned namespaces and xml-utils (which implies xerces-c). For versioned namespaces it looks you have to extend the ace vcpkg file

bold84 · 2023-05-05T11:50:16Z

ACE needs to be compiled with versioned namespaces and xml-utils (which implies xerces-c). For versioned namespaces it looks you have to extend the ace vcpkg file

And what about TAO, that is part of the ace port, as you know.

I would probably have to extend brix11 to allow such scenario, right?

jwillemsen · 2023-05-05T11:51:31Z

TAO is part of ACE, there also versioned namespaces has to be enabled. I have never used the vcpkg version of ACE/TAO for any project, not tested it at all. brix11 has the capability to specify the ACE/TAO/MPC root, maybe you can use that

This reverts commit 4fe3207.

bold84 · 2023-05-07T01:47:50Z

As @jwillemsen rightfully pointed out ( RemedyIT/axcioma#145 ), MacOS is not a supported platform (at least on arm64 I have several failing tests) and I therefore remove osx from the supports field for now.

jwillemsen · 2023-05-30T14:59:51Z

See #31718 for the ace support for versioned namespace

bold84 · 2023-05-30T15:02:49Z

See #31718 for the ace support for versioned namespace

Thank you!
I'll get back to this in a while. I have a bit of work to do first.

ClausKlein

Q: Do you wand to build taox11 only or all packages: ciaox11, and dancex11 too?

Q: How dit you test the result of this port?

IMHO: instead of install find_modules() you should export a modern CMake interface package to taox11:
see https://github.com/ClausKlein/axcioma/blob/feature/build-with-example/CMakeLists.txt for example.

ClausKlein · 2023-10-09T05:20:35Z

ports/axcioma/TAO_IDL.cmake

@@ -0,0 +1,52 @@
+find_program(TAO_IDL_COMMAND tao_idl)


The taox11 compiler is ridlc!

ClausKlein · 2023-10-09T05:21:39Z

ports/axcioma/TAO_IDL.cmake

+    add_custom_command(
+      OUTPUT ${client_source_output} ${client_header_output}
+             ${server_source_output} ${server_header_output}
+      COMMAND ${TAO_IDL_COMMAND} ARGS ${TAO_IDL_ARGS}


TAO_IDL_ARGS is not set?

ClausKlein · 2023-10-09T05:23:22Z

ports/axcioma/TAO_IDL.cmake

+  GENERATE_TAO_IDL_RULES
+  generated_client_sources
+  generated_client_headers
+  generated_server_sources
+  generated_server_headers)


This is a deprecated CMake style!
Use endmacro() without arguments.

ClausKlein · 2023-10-09T06:09:16Z

ports/axcioma/TAO_IDL.cmake

+macro(APPEND orig_string new_string)
+  if(NOT ${orig_string})
+    set(${orig_string} ${new_string})
+  else(NOT ${orig_string})
+    set(${orig_string} ${${orig_string}} ${new_string})
+  endif(NOT ${orig_string})
+endmacro(
+  APPEND
+  orig_string
+  new_string)


Not needed! see CMake list APPEND

ClausKlein · 2023-10-09T06:11:29Z

ports/axcioma/TAO_IDL.cmake

+         ${CMAKE_CURRENT_BINARY_DIR}/${server_source_output})
+    list(APPEND ${generated_server_headers}
+         ${CMAKE_CURRENT_BINARY_DIR}/${server_header_output})
+  endforeach(idl_source ${ARGN})


deprecated style!
use simply endforeach(), else(), endif(), ...

Adela0814 · 2024-01-08T08:42:44Z

Pinging @bold84 for response. Is work still being done for this PR?

added axcioma

1cf9a92

Neumann-A reviewed May 1, 2023

View reviewed changes

ports/axcioma/CONTROL Outdated Show resolved Hide resolved

bold84 added 5 commits May 2, 2023 05:21

builds on windows

dd57d04

x86-windows builds

22b59d2

disallow static-crt

c475eef

updated ci.baseline.txt

2fa8ef8

CI

10066df

Neumann-A reviewed May 3, 2023

View reviewed changes

bold84 added 9 commits May 4, 2023 06:47

Revert "updated ci.baseline.txt"

e4b75ea

Improved portfile

added osx patch

ee3e082

few improvements

8568614

few improvements

dc9fc1d

added ciaox11 and dancex11 libs

5e7589c

builds on windows again

60d56da

uncomment build part

d997952

version

5d23a38

enable osx build

8f889d8

Cheney-W assigned Adela0814 May 4, 2023

bold84 added 3 commits May 4, 2023 09:56

fixed supports

21ec0a6

Merge branch 'axcioma' of https://github.com/ORDIS-Co-Ltd/vcpkg into …

90b836e

…axcioma

fix linux

380f497

bold84 marked this pull request as ready for review May 4, 2023 05:38

added license to manifest

edc33db

Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 4, 2023

bold84 added 3 commits May 4, 2023 13:32

Cleaned up a bit and added some helpers for cmake (usage)

5c9970c

Partial reversion of "improvements" due to differing behavior of CMak…

ae8bf47

…e's copy command.

Don't build ace when axcioma is installed

4fe3207

jwillemsen mentioned this pull request May 5, 2023

MacOS support RemedyIT/axcioma#145

Draft

bold84 marked this pull request as draft May 5, 2023 20:30

Revert "Don't build ace when axcioma is installed"

6c07da9

This reverts commit 4fe3207.

Remove osx

1399a90

ClausKlein reviewed Oct 9, 2023

View reviewed changes

LilyWangLL assigned Cheney-W Feb 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[axcioma] New port (C++11 CORBA implementation TAOX11) #31203

[axcioma] New port (C++11 CORBA implementation TAOX11) #31203

bold84 commented May 1, 2023 •

edited

Loading

Neumann-A May 1, 2023

bold84 May 1, 2023

bold84 May 1, 2023

Neumann-A May 3, 2023

bold84 May 3, 2023

Neumann-A May 3, 2023

bold84 May 3, 2023

bold84 commented May 4, 2023

jwillemsen commented May 5, 2023

bold84 commented May 5, 2023

jwillemsen commented May 5, 2023 •

edited

Loading

bold84 commented May 7, 2023

jwillemsen commented May 30, 2023

bold84 commented May 30, 2023 •

edited

Loading

ClausKlein left a comment •

edited

Loading

ClausKlein Oct 9, 2023

ClausKlein Oct 9, 2023

ClausKlein Oct 9, 2023 •

edited

Loading

ClausKlein Oct 9, 2023

ClausKlein Oct 9, 2023

Adela0814 commented Jan 8, 2024



		vcpkg_execute_required_process(
		COMMAND ${BRIX11} bootstrap taox11

	if(VCPKG_TARGET_IS_MINGW)
	set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".a")
	set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX ".dll.a")
	set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".dll")
	set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "lib")
	set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "lib")
	set(VCPKG_TARGET_IMPORT_LIBRARY_PREFIX "lib")
	set(VCPKG_FIND_LIBRARY_SUFFIXES ".dll" ".dll.a" ".a" ".lib")
	set(VCPKG_FIND_LIBRARY_PREFIXES "lib" "")
	elseif(VCPKG_TARGET_IS_WINDOWS)
	set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".lib")
	set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX ".lib")
	set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".dll")
	set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX ".lib")
	set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "")
	set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "")
	set(VCPKG_TARGET_IMPORT_LIBRARY_PREFIX "")
	set(VCPKG_FIND_LIBRARY_SUFFIXES ".lib" ".dll") #This is a slight modification to CMakes value which does not include ".dll".
	set(VCPKG_FIND_LIBRARY_PREFIXES "" "lib") #This is a slight modification to CMakes value which does not include "lib".
	elseif(VCPKG_TARGET_IS_OSX)
	set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".a")
	set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX "")
	set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".dylib")
	set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "lib")
	set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "lib")
	set(VCPKG_FIND_LIBRARY_SUFFIXES ".tbd" ".dylib" ".so" ".a")
	set(VCPKG_FIND_LIBRARY_PREFIXES "lib" "")
	else()
	set(VCPKG_TARGET_STATIC_LIBRARY_SUFFIX ".a")
	set(VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX "")
	set(VCPKG_TARGET_SHARED_LIBRARY_SUFFIX ".so")
	set(VCPKG_TARGET_STATIC_LIBRARY_PREFIX "lib")
	set(VCPKG_TARGET_SHARED_LIBRARY_PREFIX "lib")
	set(VCPKG_FIND_LIBRARY_SUFFIXES ".so" ".a")
	set(VCPKG_FIND_LIBRARY_PREFIXES "lib" "")
	endif()

[axcioma] New port (C++11 CORBA implementation TAOX11) #31203

Are you sure you want to change the base?

[axcioma] New port (C++11 CORBA implementation TAOX11) #31203

Conversation

bold84 commented May 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bold84 commented May 4, 2023

jwillemsen commented May 5, 2023

bold84 commented May 5, 2023

jwillemsen commented May 5, 2023 • edited Loading

bold84 commented May 7, 2023

jwillemsen commented May 30, 2023

bold84 commented May 30, 2023 • edited Loading

ClausKlein left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClausKlein Oct 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Adela0814 commented Jan 8, 2024

bold84 commented May 1, 2023 •

edited

Loading

jwillemsen commented May 5, 2023 •

edited

Loading

bold84 commented May 30, 2023 •

edited

Loading

ClausKlein left a comment •

edited

Loading

ClausKlein Oct 9, 2023 •

edited

Loading