Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minio-cpp] chore(version): updated to v0.1.0 #26145

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

harshavardhana
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Updating minio-cpp version.

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

all/No

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Aug 3, 2022

CLA assistant check
All CLA requirements met.

@harshavardhana harshavardhana force-pushed the minio-cpp branch 4 times, most recently from 2228cb4 to 3e15792 Compare August 3, 2022 07:22
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 3, 2022
ports/minio-cpp/vcpkg.json Outdated Show resolved Hide resolved
ports/minio-cpp/vcpkg.json Outdated Show resolved Hide resolved
ports/minio-cpp/portfile.cmake Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Aug 5, 2022
@JonLiu1993
Copy link
Member

@harshavardhana, Can you take a look at this error first?

CMake Error at include/CMakeLists.txt:28 (configure_file):
  No such file or directory


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
Doxygen need to be installed to generate the doxygen documentation
-- Configuring incomplete, errors occurred!

@harshavardhana
Copy link
Contributor Author

@harshavardhana, Can you take a look at this error first?

CMake Error at include/CMakeLists.txt:28 (configure_file):
  No such file or directory


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
Doxygen need to be installed to generate the doxygen documentation
-- Configuring incomplete, errors occurred!

@balamurugana ^^

@balamurugana
Copy link

@harshavardhana, Can you take a look at this error first?

CMake Error at include/CMakeLists.txt:28 (configure_file):
  No such file or directory


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
Doxygen need to be installed to generate the doxygen documentation
-- Configuring incomplete, errors occurred!

@balamurugana ^^

@harshavardhana If we don't want to build documentation, we could use https://github.com/minio/minio-cpp/blob/main/CMakeLists.txt#L115

@harshavardhana
Copy link
Contributor Author

@harshavardhana, Can you take a look at this error first?

CMake Error at include/CMakeLists.txt:28 (configure_file):
  No such file or directory


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
Doxygen need to be installed to generate the doxygen documentation
-- Configuring incomplete, errors occurred!

This is fixed @JonLiu1993

@harshavardhana
Copy link
Contributor Author

./vcpkg install minio-cpp
Computing installation plan...
The following packages will be built and installed:
    minio-cpp[core]:x64-linux -> 0.1.0
Detecting compiler hash for triplet x64-linux...
Restored 0 package(s) from /home/harsha/.cache/vcpkg/archives in 3.553 us. Use --debug to see more details.
Installing 1/1 minio-cpp:x64-linux...
Building minio-cpp[core]:x64-linux...
-- Using cached minio-minio-cpp-v0.1.0.tar.gz.
-- Cleaning sources at /home/harsha/go/src/github.com/minio/vcpkg/buildtrees/minio-cpp/src/v0.1.0-b495fb0570.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/harsha/go/src/github.com/minio/vcpkg/downloads/minio-minio-cpp-v0.1.0.tar.gz
-- Using source at /home/harsha/go/src/github.com/minio/vcpkg/buildtrees/minio-cpp/src/v0.1.0-b495fb0570.clean
-- Configuring x64-linux
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Fixing pkgconfig file: /home/harsha/go/src/github.com/minio/vcpkg/packages/minio-cpp_x64-linux/lib/pkgconfig/miniocpp.pc
-- Fixing pkgconfig file: /home/harsha/go/src/github.com/minio/vcpkg/packages/minio-cpp_x64-linux/debug/lib/pkgconfig/miniocpp.pc
-- Installing: /home/harsha/go/src/github.com/minio/vcpkg/packages/minio-cpp_x64-linux/share/minio-cpp/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: "/home/harsha/.cache/vcpkg/archives/38/381a40e104680b7486075392cf93298083791229148eeec628411c542d678a39.zip"
Elapsed time to handle minio-cpp:x64-linux: 24.8 s

Total elapsed time: 24.99 s

github-actions[bot]
github-actions bot previously approved these changes Aug 5, 2022
@JonLiu1993
Copy link
Member

@harshavardhana, Can you successfully install window triplet locally?

D:\buildtrees\minio-cpp\src\v0.1.0-b495fb0570.clean\include\http.h(19): fatal error C1083: Cannot open include file: 'arpa/inet.h': No such file or directory

@harshavardhana
Copy link
Contributor Author

@JonLiu1993 I do not have windows and perhaps I never will so there is no way for me to test it. This library would be Linux only for the most part and OSX (experimental) if we can get it to compile there.

Also I have hard time finding builds logs for the failures that we would love to fix can you help where these are located?

@JonLiu1993
Copy link
Member

@harshavardhana, Can you successfully install window triplet locally?

D:\buildtrees\minio-cpp\src\v0.1.0-b495fb0570.clean\include\http.h(19): fatal error C1083: Cannot open include file: 'arpa/inet.h': No such file or directory

arpa/inet.h is an include used on Unix-like systems, so I think this is the reason why windows are not supported

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 8, 2022
@BillyONeal BillyONeal merged commit bea0562 into microsoft:master Aug 8, 2022
@BillyONeal
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants