Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openssl] remove no-stdio for iOS #26023

Merged
merged 2 commits into from
Aug 1, 2022
Merged

[openssl] remove no-stdio for iOS #26023

merged 2 commits into from
Aug 1, 2022

Conversation

inhzus
Copy link
Contributor

@inhzus inhzus commented Jul 28, 2022

Describe the pull request

  • What does your PR fix?

    Fixes [poco] Build error #25990
    Remove a configure option, no-stdio, so PEM_read_PrivateKey, PEM_read_PUBKEY and some other PEM related functions shall be compiled.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Jul 28, 2022

CLA assistant check
All CLA requirements met.

@LilyWangLL LilyWangLL self-assigned this Jul 28, 2022
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 28, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 29, 2022
@ras0219-msft
Copy link
Contributor

/azp run

@ras0219-msft
Copy link
Contributor

This seems correct according to openssl/openssl#9037, thanks for the PR! LGTM once the CI is green.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[poco] Build error
4 participants