[vtk] use interface target instead of alias for lz4 #23352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney-W
added
category:port-bug
dg0yt
reviewed
Mar 3, 2022
| +if(NOT TARGET LZ4::LZ4) | ||
| +add_library(LZ4::LZ4 ALIAS lz4::lz4) | ||
| + add_library(LZ4::LZ4 INTERFACE IMPORTED) | ||
| + target_link_libraries(LZ4::LZ4 INTERFACE lz4::lz4) |
There was a problem hiding this comment.
CMake 3.11 is needed to use target_link_libraries with imported targets. (https://cmake.org/cmake/help/v3.22/release/3.11.html?highlight=target_link_libraries#commands).
But IIUC this file may be installed and eventually be used in user project where vcpkg supports CMake 3.7.2.
There was a problem hiding this comment.
The current code also requires 3.11 due to an alias target targeting a GLOBAL IMPORTED target. Furthermore I think this doesn't matter at all since find_package(vtk) will most likely require a higher CMake any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.