Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[winsparkle] Intitial commit with binary copy #23194

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

daschuer
Copy link
Contributor

This PR adds winsparkle to the ports. This is the alternative solution, copying the prebuild binaries as suggested here:
#17563

Fixes #16607

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Only windows x64 and x86 targets are supported. Other triplet settings are ignored because this is a binary copy of the recompiled binaries.

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 21, 2022
@Cheney-W
Copy link
Contributor

Could you please solve the failure in winsparkle:x64-windows-static and winsparkle:x64-windows-static-md?

DLLs should not be present in a static build, but the following DLLs were found:
    D:/packages/winsparkle_x64-windows-static-md/bin/WinSparkle.dll
    D:/packages/winsparkle_x64-windows-static-md/debug/bin/WinSparkle.dll
There should be no bin\ directory in a static build, but D:\packages\winsparkle_x64-windows-static-md\bin is present.
There should be no debug\bin\ directory in a static build, but D:\packages\winsparkle_x64-windows-static-md\debug\bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them
    if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
        file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
    endif()
Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile:
    C:\a\1\s\ports\winsparkle\portfile.cmake

DLLs should not be present in a static build, but the following DLLs were found:
    D:/packages/winsparkle_x64-windows-static/bin/WinSparkle.dll
    D:/packages/winsparkle_x64-windows-static/debug/bin/WinSparkle.dll

@daschuer
Copy link
Contributor Author

In this case it is a false positive. Do you have an idea how to silence it?

@daschuer
Copy link
Contributor Author

set(VCPKG_POLICY_DLLS_IN_STATIC_LIBRARY enabled)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for winsparkle but no changes to version or port version.
-- Version: 0.7.0
-- Old SHA: 3de12a4bb10bb91edb9bb06ce6d089340cd488eb
-- New SHA: 0d756f506e6a79a2a79706f9080c05b45e7df882
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@dg0yt
Copy link
Contributor

dg0yt commented Feb 21, 2022

In this case it is a false positive.

What does this mean? There are no DLLs? Or there are never static libs? Or a mix is expected?
There is also

vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)

@daschuer
Copy link
Contributor Author

I have now set VCPKG_POLICY_DLLS_IN_STATIC_LIBRARY to disable the false positive error.

This port just copied the recompiled DLLs over. There are no static libs by design, because it is desired to update the application and the winsparkle DLL independently.

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 22, 2022
@vicroms vicroms added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 22, 2022
@vicroms vicroms merged commit ec7b21c into microsoft:master Mar 2, 2022
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 3, 2022
@daschuer daschuer deleted the winsparkle_cpy branch January 5, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] winsparkle
4 participants