-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[brpc] Fix build failed when protobuf update to 3.19.3 #22685
[brpc] Fix build failed when protobuf update to 3.19.3 #22685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/brpc/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
brpc version 1.0.0 has been released in the mean-time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5fcea86177e7c81fa90e721bba2822649dd4b982 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/brpc.json b/versions/b-/brpc.json
index fe1bc39..f271e64 100644
--- a/versions/b-/brpc.json
+++ b/versions/b-/brpc.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "6ecf23c31d271789f789a3d61eea67976cbfe007",
+ "git-tree": "17c9dc7c90d1f6e94cf78407c73e4e1feeaf1210",
"version-string": "0.9.7",
"port-version": 4
},
Yes, but this bug doesn't fix in new release, so I just add patch to fix bug. |
…LilyWang/update_brpc # Conflicts: # versions/b-/brpc.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for brpc but no changes to version or port version.
-- Version: 0.9.7#4
-- Old SHA: 7c6f7c8a882730bd20874fb5832081105a169c7a
-- New SHA: 17c9dc7c90d1f6e94cf78407c73e4e1feeaf1210
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2e34a79a814551424d9b1a981b3b110e0a8fbdfd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/brpc.json b/versions/b-/brpc.json
index ee8a252..c27ea50 100644
--- a/versions/b-/brpc.json
+++ b/versions/b-/brpc.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "17c9dc7c90d1f6e94cf78407c73e4e1feeaf1210",
+ "git-tree": "5e7bd33f7f9ebd4d92ce3e7d5e56e3c5b4223198",
"version-string": "0.9.7",
"port-version": 5
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2e34a79a814551424d9b1a981b3b110e0a8fbdfd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/brpc.json b/versions/b-/brpc.json
index c27ea50..b07abd2 100644
--- a/versions/b-/brpc.json
+++ b/versions/b-/brpc.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "5e7bd33f7f9ebd4d92ce3e7d5e56e3c5b4223198",
+ "git-tree": "9cc562fdf90d317b47bf0bb5dbbc10e33b64af55",
"version-string": "0.9.7",
"port-version": 5
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2e34a79a814551424d9b1a981b3b110e0a8fbdfd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/brpc.json b/versions/b-/brpc.json
index b07abd2..4ac0070 100644
--- a/versions/b-/brpc.json
+++ b/versions/b-/brpc.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "9cc562fdf90d317b47bf0bb5dbbc10e33b64af55",
+ "git-tree": "eb37098c32016db48b15a29bd31b08087c7b5d0e",
"version-string": "0.9.7",
"port-version": 5
},
LGTM, thanks for the PR! |
When protobuf update to version 3.19.3, brpc build failed with the following error:
The upstream PR apache/brpc#1679 fixed this error, add patch to merge this change to VCPKG.