Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] binarycaching.md: NuGet requires to set API Key for source #22191

Merged
merged 1 commit into from
Aug 5, 2022
Merged

[docs] binarycaching.md: NuGet requires to set API Key for source #22191

merged 1 commit into from
Aug 5, 2022

Conversation

ivanstepanovftw
Copy link
Contributor

@ivanstepanovftw ivanstepanovftw commented Dec 24, 2021 •
edited
Loading

Describe the pull request

@ghost
Copy link

ghost commented Dec 24, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JackBoosY
Copy link
Contributor

Can you please sign CLA first?

@JackBoosY JackBoosY added the category:documentation To resolve the issue, documentation will need to be updated label Dec 24, 2021
@ivanstepanovftw
Copy link
Contributor Author

I am waiting my company approval

@BillyONeal BillyONeal mentioned this pull request Feb 15, 2022
Closed
@JackBoosY
Copy link
Contributor

Ping for response.

ResearchDaniel added a commit to SciVis/VisualNeuro that referenced this pull request May 5, 2022
@ResearchDaniel
CI: NuGet caching fix
b38bbd9 
See microsoft/vcpkg#22191
ResearchDaniel added a commit to SciVis/VisualNeuro that referenced this pull request May 5, 2022
@ResearchDaniel
CI: NuGet caching fix
08bbeb1 
See microsoft/vcpkg#22191
@JackBoosY
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@JackBoosY JackBoosY closed this May 7, 2022
@ivanstepanovftw
Copy link
Contributor Author

ivanstepanovftw commented Jun 22, 2022 •
edited
Loading

Signed SLA

Please reopen

@JackBoosY JackBoosY reopened this Jun 23, 2022
@JackBoosY
Copy link
Contributor

Please click "Ready for review" if this PR is ready.

@JackBoosY
Copy link
Contributor

Ping for response again.

@ivanstepanovftw ivanstepanovftw marked this pull request as ready for review July 15, 2022 12:46
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 5, 2022
ras0219-msft
ras0219-msft approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the PR!

@BillyONeal BillyONeal merged commit 4147b34 into microsoft:master Aug 5, 2022
@BillyONeal
Copy link
Member

Thank you!

@renovate-bot renovate-bot mentioned this pull request Aug 16, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Aug 16, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@github-actions GitHub Actions github-actions approved these changes

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[binarycaching] Pushing NuGet to GitHub failed
5 participants
@ivanstepanovftw @JackBoosY @BillyONeal @ras0219-msft @PhoebeHui