[scripts-audit] Make buildsystem (port) #19753

JackBoosY · 2021-08-26T08:58:08Z

Comply with the regulations in https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/cmake-guidelines.md

Convert functions and variables
remove/deprecate ENABLE_INSTALL (depending on whether it's used) (see also INSTALL_TARGET)
No because some port's makefile doesn't contains install command.
look and see if MAKEFILE is used usefully vs SUBPATH; if not, deprecate/remove depending on whether it's used
Yes, will do this job after [gettext] Remove SUBPATH, add iconv linking info #20090 merge.
Modify docs
Improve code
Test
Depends on PR [scripts-audit] Make buildsystem #20165

Related: #16188.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout dd3d6df5001d49f954bc39b73a4c49ae3c9e8d15 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6364739..f835931 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6636,6 +6636,10 @@
       "baseline": "3",
       "port-version": 0
     },
+    "vcpkg-make": {
+      "baseline": "2021-08-25",
+      "port-version": 0
+    },
     "vcpkg-pkgconfig-get-modules": {
       "baseline": "2021-04-02",
       "port-version": 1

…jack/make_buildsystem

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: a15a15f10c7e4613b91c968df875dc9a660feadc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: a15a15f10c7e4613b91c968df875dc9a660feadc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 21935b744dc411e0fb1926618fdfb18c67d4b188 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/g-/gettext.json b/versions/g-/gettext.json
index c43b54a..b555eae 100644
--- a/versions/g-/gettext.json
+++ b/versions/g-/gettext.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "100b45fb256256a452eb8c53e5201c84f29feb2e",
+      "git-tree": "bcf4661e45e7f47d1e736849b0506941bb59821a",
       "version": "0.21",
       "port-version": 6
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: a15a15f10c7e4613b91c968df875dc9a660feadc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: a15a15f10c7e4613b91c968df875dc9a660feadc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: a15a15f10c7e4613b91c968df875dc9a660feadc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: a15a15f10c7e4613b91c968df875dc9a660feadc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

dg0yt · 2021-09-07T07:47:14Z

ports/vcpkg-make/vcpkg_make_configure.cmake

+
+    set(requires_autogen FALSE) # use autogen.sh
+    set(requires_autoconfig FALSE) # use autotools and configure.ac
+    if(EXISTS "${src_dir}/configure" AND "${src_dir}/configure.ac") # remove configure; rerun autoconf


This line misses an EXISTS after AND. This bug is present already in the legacy function, but the script always had too many PRs pending...
IMO this whole if ... endif block should be reviewed. For example, I don't feel like I would want to see autoconfig being run when SKIP_CONFIGURE was passed as an argument.

We should always generate configure when configure.ac exists, and we need to provide a new option to skip this step.
So, AUTOCONFIG should be depreciated.

@Neumann-A Do you agreed?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: 436ebcb239031050c028bbfd5a1d25992e3cd6d0
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for fontconfig but no changes to version or port version.
-- Version: 2.13.94
-- Old SHA: 73929965b1d7992064fec1f69c6225a3d73a262b
-- New SHA: e1a8722bdfde5673663d12b2f359ef476b6f7be6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/apr-util.json b/versions/a-/apr-util.json
index a2629d3..48d655e 100644
--- a/versions/a-/apr-util.json
+++ b/versions/a-/apr-util.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6e039df30db545141c59425a585296777b110c7d",
+      "version-string": "1.6.1",
+      "port-version": 5
+    },
     {
       "git-tree": "cf1a0e97d00a5748dc58db7d0a5da0fd7d5efb66",
       "version-string": "1.6.1",
diff --git a/versions/a-/apr.json b/versions/a-/apr.json
index d652415..c73d5fc 100644
--- a/versions/a-/apr.json
+++ b/versions/a-/apr.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f3cb36f13b9cab10318f247494b23e5d2009f2ed",
+      "version": "1.7.0",
+      "port-version": 5
+    },
     {
       "git-tree": "b9e93acdaa680398eaed361f1df530096ded84ff",
       "version": "1.7.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index a2c6827..74a5eeb 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -106,11 +106,11 @@
     },
     "apr": {
       "baseline": "1.7.0",
-      "port-version": 4
+      "port-version": 5
     },
     "apr-util": {
       "baseline": "1.6.1",
-      "port-version": 4
+      "port-version": 5
     },
     "apsi": {
       "baseline": "0.2.0",
@@ -2302,7 +2302,7 @@
     },
     "gdal": {
       "baseline": "3.2.2",
-      "port-version": 5
+      "port-version": 6
     },
     "gdcm": {
       "baseline": "3.0.7",
@@ -2350,7 +2350,7 @@
     },
     "gettext": {
       "baseline": "0.21",
-      "port-version": 6
+      "port-version": 7
     },
     "gettimeofday": {
       "baseline": "2017-10-14",
@@ -2586,7 +2586,7 @@
     },
     "healpix": {
       "baseline": "1.12.10",
-      "port-version": 8
+      "port-version": 9
     },
     "hedley": {
       "baseline": "15",
@@ -2630,7 +2630,7 @@
     },
     "hunspell": {
       "baseline": "1.7.0",
-      "port-version": 5
+      "port-version": 6
     },
     "hwloc": {
       "baseline": "2.2.0",
@@ -2650,7 +2650,7 @@
     },
     "icu": {
       "baseline": "69.1",
-      "port-version": 14
+      "port-version": 15
     },
     "ideviceinstaller": {
       "baseline": "1.1.2.23",
@@ -3394,7 +3394,7 @@
     },
     "libiconv": {
       "baseline": "1.16",
-      "port-version": 11
+      "port-version": 12
     },
     "libics": {
       "baseline": "1.6.5",
@@ -3834,7 +3834,7 @@
     },
     "liburing": {
       "baseline": "2.0",
-      "port-version": 0
+      "port-version": 1
     },
     "libusb": {
       "baseline": "1.0.24",
@@ -4478,7 +4478,7 @@
     },
     "ncurses": {
       "baseline": "6.2",
-      "port-version": 1
+      "port-version": 2
     },
     "neargye-semver": {
       "baseline": "0.2.2",
@@ -6266,7 +6266,7 @@
     },
     "starlink-ast": {
       "baseline": "9.2.4",
-      "port-version": 1
+      "port-version": 2
     },
     "status-code": {
       "baseline": "1.0.0-ab3cd821",
diff --git a/versions/g-/gdal.json b/versions/g-/gdal.json
index bf73dab..6173413 100644
--- a/versions/g-/gdal.json
+++ b/versions/g-/gdal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d2eb322f95fbca88afb18a0ffda8477ad87db103",
+      "version-semver": "3.2.2",
+      "port-version": 6
+    },
     {
       "git-tree": "3f821ae473a38c3ceac861552f560da4a9109ff8",
       "version-semver": "3.2.2",
diff --git a/versions/g-/gettext.json b/versions/g-/gettext.json
index adb7fea..fbc6913 100644
--- a/versions/g-/gettext.json
+++ b/versions/g-/gettext.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d1eba48f67dbbd9a07b89b0850e1e42777a409b2",
+      "version": "0.21",
+      "port-version": 7
+    },
     {
       "git-tree": "72394a1e7b0ea6333d78849f864c4b7bc8c7e8dc",
       "version": "0.21",
diff --git a/versions/h-/healpix.json b/versions/h-/healpix.json
index a85f529..87a3d63 100644
--- a/versions/h-/healpix.json
+++ b/versions/h-/healpix.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0eb7e3ec2016e2f927cb7c943f9434b5252366ec",
+      "version-string": "1.12.10",
+      "port-version": 9
+    },
     {
       "git-tree": "38bd9d397f3ba4e227f09a36ecb0af034f5f0c98",
       "version-string": "1.12.10",
diff --git a/versions/h-/hunspell.json b/versions/h-/hunspell.json
index af5756c..c5b4354 100644
--- a/versions/h-/hunspell.json
+++ b/versions/h-/hunspell.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3d6529e3845ea7ae9aadc6abeef30985d863e91e",
+      "version": "1.7.0",
+      "port-version": 6
+    },
     {
       "git-tree": "2a0514dd8b3893b6d3a502fbf55156e9e971d6f7",
       "version": "1.7.0",
diff --git a/versions/i-/icu.json b/versions/i-/icu.json
index bac44fa..a706035 100644
--- a/versions/i-/icu.json
+++ b/versions/i-/icu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "ac4a4657860202b1271df82c384aa644ed4cc743",
+      "version": "69.1",
+      "port-version": 15
+    },
     {
       "git-tree": "2632dd55c20f6830027ae1e167524817b1a9d7ec",
       "version": "69.1",
diff --git a/versions/l-/libiconv.json b/versions/l-/libiconv.json
index 9423b27..7ecf38d 100644
--- a/versions/l-/libiconv.json
+++ b/versions/l-/libiconv.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "534ed78492de209c5a752b53ef6567b61a577c3d",
+      "version": "1.16",
+      "port-version": 12
+    },
     {
       "git-tree": "f82980bff6c23bcccd043300679ebf8afa3e0a22",
       "version": "1.16",
diff --git a/versions/l-/liburing.json b/versions/l-/liburing.json
index 0ec46a4..3cf5fcb 100644
--- a/versions/l-/liburing.json
+++ b/versions/l-/liburing.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9eea2e30573c9bc095a193076d15896a98c6324d",
+      "version": "2.0",
+      "port-version": 1
+    },
     {
       "git-tree": "b4d90242721d15d6dc5287690c3b8d42c2e8d0f0",
       "version": "2.0",
diff --git a/versions/n-/ncurses.json b/versions/n-/ncurses.json
index 135f3c3..1ef2b99 100644
--- a/versions/n-/ncurses.json
+++ b/versions/n-/ncurses.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "dcdfbaf6aaf3b24ac3c4c189b05d82c0f6954d90",
+      "version-string": "6.2",
+      "port-version": 2
+    },
     {
       "git-tree": "f196044f9f7779e0bdb54015dbd3be84aaa00820",
       "version-string": "6.2",
diff --git a/versions/s-/starlink-ast.json b/versions/s-/starlink-ast.json
index a724950..bc4dbc3 100644
--- a/versions/s-/starlink-ast.json
+++ b/versions/s-/starlink-ast.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "7004d96cde4ac906b500d5bab5d7b15b27ea85c5",
+      "version-semver": "9.2.4",
+      "port-version": 2
+    },
     {
       "git-tree": "2fecd468269d73b6e8f29a297c4f7db771ea37c4",
       "version-semver": "9.2.4",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/apr-util/portfile.cmake
ports/apr/portfile.cmake
ports/ffnvcodec/portfile.cmake
ports/gdal/portfile.cmake
ports/gettext/portfile.cmake
ports/healpix/portfile.cmake
ports/hunspell/portfile.cmake
ports/icu/portfile.cmake
ports/libiconv/portfile.cmake
ports/libproxy/portfile.cmake
ports/liburing/portfile.cmake
ports/ncurses/portfile.cmake
ports/starlink-ast/portfile.cmake
ports/vcpkg-make/portfile.cmake
ports/x264/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: 436ebcb239031050c028bbfd5a1d25992e3cd6d0
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for fontconfig but no changes to version or port version.
-- Version: 2.13.94
-- Old SHA: 73929965b1d7992064fec1f69c6225a3d73a262b
-- New SHA: e1a8722bdfde5673663d12b2f359ef476b6f7be6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/apr-util.json b/versions/a-/apr-util.json
index a2629d3..48d655e 100644
--- a/versions/a-/apr-util.json
+++ b/versions/a-/apr-util.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6e039df30db545141c59425a585296777b110c7d",
+      "version-string": "1.6.1",
+      "port-version": 5
+    },
     {
       "git-tree": "cf1a0e97d00a5748dc58db7d0a5da0fd7d5efb66",
       "version-string": "1.6.1",
diff --git a/versions/a-/apr.json b/versions/a-/apr.json
index d652415..c73d5fc 100644
--- a/versions/a-/apr.json
+++ b/versions/a-/apr.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f3cb36f13b9cab10318f247494b23e5d2009f2ed",
+      "version": "1.7.0",
+      "port-version": 5
+    },
     {
       "git-tree": "b9e93acdaa680398eaed361f1df530096ded84ff",
       "version": "1.7.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index a2c6827..74a5eeb 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -106,11 +106,11 @@
     },
     "apr": {
       "baseline": "1.7.0",
-      "port-version": 4
+      "port-version": 5
     },
     "apr-util": {
       "baseline": "1.6.1",
-      "port-version": 4
+      "port-version": 5
     },
     "apsi": {
       "baseline": "0.2.0",
@@ -2302,7 +2302,7 @@
     },
     "gdal": {
       "baseline": "3.2.2",
-      "port-version": 5
+      "port-version": 6
     },
     "gdcm": {
       "baseline": "3.0.7",
@@ -2350,7 +2350,7 @@
     },
     "gettext": {
       "baseline": "0.21",
-      "port-version": 6
+      "port-version": 7
     },
     "gettimeofday": {
       "baseline": "2017-10-14",
@@ -2586,7 +2586,7 @@
     },
     "healpix": {
       "baseline": "1.12.10",
-      "port-version": 8
+      "port-version": 9
     },
     "hedley": {
       "baseline": "15",
@@ -2630,7 +2630,7 @@
     },
     "hunspell": {
       "baseline": "1.7.0",
-      "port-version": 5
+      "port-version": 6
     },
     "hwloc": {
       "baseline": "2.2.0",
@@ -2650,7 +2650,7 @@
     },
     "icu": {
       "baseline": "69.1",
-      "port-version": 14
+      "port-version": 15
     },
     "ideviceinstaller": {
       "baseline": "1.1.2.23",
@@ -3394,7 +3394,7 @@
     },
     "libiconv": {
       "baseline": "1.16",
-      "port-version": 11
+      "port-version": 12
     },
     "libics": {
       "baseline": "1.6.5",
@@ -3834,7 +3834,7 @@
     },
     "liburing": {
       "baseline": "2.0",
-      "port-version": 0
+      "port-version": 1
     },
     "libusb": {
       "baseline": "1.0.24",
@@ -4478,7 +4478,7 @@
     },
     "ncurses": {
       "baseline": "6.2",
-      "port-version": 1
+      "port-version": 2
     },
     "neargye-semver": {
       "baseline": "0.2.2",
@@ -6266,7 +6266,7 @@
     },
     "starlink-ast": {
       "baseline": "9.2.4",
-      "port-version": 1
+      "port-version": 2
     },
     "status-code": {
       "baseline": "1.0.0-ab3cd821",
diff --git a/versions/g-/gdal.json b/versions/g-/gdal.json
index bf73dab..6173413 100644
--- a/versions/g-/gdal.json
+++ b/versions/g-/gdal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d2eb322f95fbca88afb18a0ffda8477ad87db103",
+      "version-semver": "3.2.2",
+      "port-version": 6
+    },
     {
       "git-tree": "3f821ae473a38c3ceac861552f560da4a9109ff8",
       "version-semver": "3.2.2",
diff --git a/versions/g-/gettext.json b/versions/g-/gettext.json
index adb7fea..fbc6913 100644
--- a/versions/g-/gettext.json
+++ b/versions/g-/gettext.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d1eba48f67dbbd9a07b89b0850e1e42777a409b2",
+      "version": "0.21",
+      "port-version": 7
+    },
     {
       "git-tree": "72394a1e7b0ea6333d78849f864c4b7bc8c7e8dc",
       "version": "0.21",
diff --git a/versions/h-/healpix.json b/versions/h-/healpix.json
index a85f529..87a3d63 100644
--- a/versions/h-/healpix.json
+++ b/versions/h-/healpix.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0eb7e3ec2016e2f927cb7c943f9434b5252366ec",
+      "version-string": "1.12.10",
+      "port-version": 9
+    },
     {
       "git-tree": "38bd9d397f3ba4e227f09a36ecb0af034f5f0c98",
       "version-string": "1.12.10",
diff --git a/versions/h-/hunspell.json b/versions/h-/hunspell.json
index af5756c..c5b4354 100644
--- a/versions/h-/hunspell.json
+++ b/versions/h-/hunspell.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3d6529e3845ea7ae9aadc6abeef30985d863e91e",
+      "version": "1.7.0",
+      "port-version": 6
+    },
     {
       "git-tree": "2a0514dd8b3893b6d3a502fbf55156e9e971d6f7",
       "version": "1.7.0",
diff --git a/versions/i-/icu.json b/versions/i-/icu.json
index bac44fa..a706035 100644
--- a/versions/i-/icu.json
+++ b/versions/i-/icu.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "ac4a4657860202b1271df82c384aa644ed4cc743",
+      "version": "69.1",
+      "port-version": 15
+    },
     {
       "git-tree": "2632dd55c20f6830027ae1e167524817b1a9d7ec",
       "version": "69.1",
diff --git a/versions/l-/libiconv.json b/versions/l-/libiconv.json
index 9423b27..7ecf38d 100644
--- a/versions/l-/libiconv.json
+++ b/versions/l-/libiconv.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "534ed78492de209c5a752b53ef6567b61a577c3d",
+      "version": "1.16",
+      "port-version": 12
+    },
     {
       "git-tree": "f82980bff6c23bcccd043300679ebf8afa3e0a22",
       "version": "1.16",
diff --git a/versions/l-/liburing.json b/versions/l-/liburing.json
index 0ec46a4..3cf5fcb 100644
--- a/versions/l-/liburing.json
+++ b/versions/l-/liburing.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9eea2e30573c9bc095a193076d15896a98c6324d",
+      "version": "2.0",
+      "port-version": 1
+    },
     {
       "git-tree": "b4d90242721d15d6dc5287690c3b8d42c2e8d0f0",
       "version": "2.0",
diff --git a/versions/n-/ncurses.json b/versions/n-/ncurses.json
index 135f3c3..1ef2b99 100644
--- a/versions/n-/ncurses.json
+++ b/versions/n-/ncurses.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "dcdfbaf6aaf3b24ac3c4c189b05d82c0f6954d90",
+      "version-string": "6.2",
+      "port-version": 2
+    },
     {
       "git-tree": "f196044f9f7779e0bdb54015dbd3be84aaa00820",
       "version-string": "6.2",
diff --git a/versions/s-/starlink-ast.json b/versions/s-/starlink-ast.json
index a724950..bc4dbc3 100644
--- a/versions/s-/starlink-ast.json
+++ b/versions/s-/starlink-ast.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "7004d96cde4ac906b500d5bab5d7b15b27ea85c5",
+      "version-semver": "9.2.4",
+      "port-version": 2
+    },
     {
       "git-tree": "2fecd468269d73b6e8f29a297c4f7db771ea37c4",
       "version-semver": "9.2.4",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/apr-util/portfile.cmake
ports/apr/portfile.cmake
ports/ffnvcodec/portfile.cmake
ports/gdal/portfile.cmake
ports/gettext/portfile.cmake
ports/healpix/portfile.cmake
ports/hunspell/portfile.cmake
ports/icu/portfile.cmake
ports/libiconv/portfile.cmake
ports/libproxy/portfile.cmake
ports/liburing/portfile.cmake
ports/ncurses/portfile.cmake
ports/starlink-ast/portfile.cmake
ports/vcpkg-make/portfile.cmake
ports/x264/portfile.cmake

JackBoosY · 2021-09-26T08:45:46Z

Will continue this after #20165 merge.

…jack/make_buildsystem

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for fontconfig but no changes to version or port version.
-- Version: 2.13.94
-- Old SHA: 73929965b1d7992064fec1f69c6225a3d73a262b
-- New SHA: e1a8722bdfde5673663d12b2f359ef476b6f7be6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for icu but no changes to version or port version.
-- Version: 69.1#15
-- Old SHA: 2d08c0ceb1777074f3b31fe51e386c9ece0ca8cd
-- New SHA: a2d9788244b57aaa5e6e17cc8edcb8bf878e83ab
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for starlink-ast but no changes to version or port version.
-- Version: 9.2.4#2
-- Old SHA: 487c5e318ce957c09647d0d74a2b5b4a4e99ffef
-- New SHA: 42168dc339e1d919401bc1f2a3315807323372a1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: 436ebcb239031050c028bbfd5a1d25992e3cd6d0
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a4c65c2f71c582a761bedb49c550b777926310c9 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/apr-util.json b/versions/a-/apr-util.json
index a2629d38..48d655e2 100644
--- a/versions/a-/apr-util.json
+++ b/versions/a-/apr-util.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6e039df30db545141c59425a585296777b110c7d",
+      "version-string": "1.6.1",
+      "port-version": 5
+    },
     {
       "git-tree": "cf1a0e97d00a5748dc58db7d0a5da0fd7d5efb66",
       "version-string": "1.6.1",
diff --git a/versions/a-/apr.json b/versions/a-/apr.json
index d652415a..c73d5fc3 100644
--- a/versions/a-/apr.json
+++ b/versions/a-/apr.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f3cb36f13b9cab10318f247494b23e5d2009f2ed",
+      "version": "1.7.0",
+      "port-version": 5
+    },
     {
       "git-tree": "b9e93acdaa680398eaed361f1df530096ded84ff",
       "version": "1.7.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index eb544b02..50dd9a92 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -106,11 +106,11 @@
     },
     "apr": {
       "baseline": "1.7.0",
-      "port-version": 4
+      "port-version": 5
     },
     "apr-util": {
       "baseline": "1.6.1",
-      "port-version": 4
+      "port-version": 5
     },
     "apsi": {
       "baseline": "0.3.1",
@@ -2338,7 +2338,7 @@
     },
     "gdal": {
       "baseline": "3.3.2",
-      "port-version": 1
+      "port-version": 2
     },
     "gdcm": {
       "baseline": "3.0.7",
@@ -2390,7 +2390,7 @@
     },
     "gettext": {
       "baseline": "0.21",
-      "port-version": 6
+      "port-version": 7
     },
     "gettimeofday": {
       "baseline": "2017-10-14",
@@ -2638,7 +2638,7 @@
     },
     "healpix": {
       "baseline": "1.12.10",
-      "port-version": 8
+      "port-version": 9
     },
     "hedley": {
       "baseline": "15",
@@ -2682,7 +2682,7 @@
     },
     "hunspell": {
       "baseline": "1.7.0",
-      "port-version": 5
+      "port-version": 6
     },
     "hwloc": {
       "baseline": "2.2.0",
@@ -3482,7 +3482,7 @@
     },
     "libiconv": {
       "baseline": "1.16",
-      "port-version": 11
+      "port-version": 12
     },
     "libics": {
       "baseline": "1.6.5",
@@ -3926,7 +3926,7 @@
     },
     "liburing": {
       "baseline": "2.0",
-      "port-version": 0
+      "port-version": 1
     },
     "libusb": {
       "baseline": "1.0.24",
@@ -4570,7 +4570,7 @@
     },
     "ncurses": {
       "baseline": "6.2",
-      "port-version": 1
+      "port-version": 2
     },
     "neargye-semver": {
       "baseline": "0.3.0",
diff --git a/versions/g-/gdal.json b/versions/g-/gdal.json
index af74f900..bcff6770 100644
--- a/versions/g-/gdal.json
+++ b/versions/g-/gdal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0ba46f63f70a8d7ef1ff2253e48d4e45b0b0f629",
+      "version-semver": "3.3.2",
+      "port-version": 2
+    },
     {
       "git-tree": "6e90412cd51170a5ea63a0067005bb3afc3c6c36",
       "version-semver": "3.3.2",
diff --git a/versions/g-/gettext.json b/versions/g-/gettext.json
index adb7fea9..fbc69139 100644
--- a/versions/g-/gettext.json
+++ b/versions/g-/gettext.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d1eba48f67dbbd9a07b89b0850e1e42777a409b2",
+      "version": "0.21",
+      "port-version": 7
+    },
     {
       "git-tree": "72394a1e7b0ea6333d78849f864c4b7bc8c7e8dc",
       "version": "0.21",
diff --git a/versions/h-/healpix.json b/versions/h-/healpix.json
index a85f5293..87a3d636 100644
--- a/versions/h-/healpix.json
+++ b/versions/h-/healpix.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0eb7e3ec2016e2f927cb7c943f9434b5252366ec",
+      "version-string": "1.12.10",
+      "port-version": 9
+    },
     {
       "git-tree": "38bd9d397f3ba4e227f09a36ecb0af034f5f0c98",
       "version-string": "1.12.10",
diff --git a/versions/h-/hunspell.json b/versions/h-/hunspell.json
index af5756c9..c5b4354f 100644
--- a/versions/h-/hunspell.json
+++ b/versions/h-/hunspell.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3d6529e3845ea7ae9aadc6abeef30985d863e91e",
+      "version": "1.7.0",
+      "port-version": 6
+    },
     {
       "git-tree": "2a0514dd8b3893b6d3a502fbf55156e9e971d6f7",
       "version": "1.7.0",
diff --git a/versions/l-/libiconv.json b/versions/l-/libiconv.json
index 9423b271..7ecf38d5 100644
--- a/versions/l-/libiconv.json
+++ b/versions/l-/libiconv.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "534ed78492de209c5a752b53ef6567b61a577c3d",
+      "version": "1.16",
+      "port-version": 12
+    },
     {
       "git-tree": "f82980bff6c23bcccd043300679ebf8afa3e0a22",
       "version": "1.16",
diff --git a/versions/l-/liburing.json b/versions/l-/liburing.json
index 0ec46a4a..3cf5fcb9 100644
--- a/versions/l-/liburing.json
+++ b/versions/l-/liburing.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9eea2e30573c9bc095a193076d15896a98c6324d",
+      "version": "2.0",
+      "port-version": 1
+    },
     {
       "git-tree": "b4d90242721d15d6dc5287690c3b8d42c2e8d0f0",
       "version": "2.0",
diff --git a/versions/n-/ncurses.json b/versions/n-/ncurses.json
index 135f3c3b..1ef2b997 100644
--- a/versions/n-/ncurses.json
+++ b/versions/n-/ncurses.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "dcdfbaf6aaf3b24ac3c4c189b05d82c0f6954d90",
+      "version-string": "6.2",
+      "port-version": 2
+    },
     {
       "git-tree": "f196044f9f7779e0bdb54015dbd3be84aaa00820",
       "version-string": "6.2",
diff --git a/versions/x-/x264.json b/versions/x-/x264.json
index 793b3059..cae2f1f2 100644
--- a/versions/x-/x264.json
+++ b/versions/x-/x264.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "8146fd54bc8d5884cd76ec4139a1ea61ea23d3de",
+      "git-tree": "d95c7bd4f42aa5f0ce47b7e68fc8aad1de9566d7",
       "version-string": "157-303c484ec828ed0",
       "port-version": 17
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/apr-util/portfile.cmake
ports/apr/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for fontconfig but no changes to version or port version.
-- Version: 2.13.94
-- Old SHA: 73929965b1d7992064fec1f69c6225a3d73a262b
-- New SHA: e1a8722bdfde5673663d12b2f359ef476b6f7be6
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for icu but no changes to version or port version.
-- Version: 69.1#15
-- Old SHA: 2d08c0ceb1777074f3b31fe51e386c9ece0ca8cd
-- New SHA: a2d9788244b57aaa5e6e17cc8edcb8bf878e83ab
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for starlink-ast but no changes to version or port version.
-- Version: 9.2.4#2
-- Old SHA: 487c5e318ce957c09647d0d74a2b5b4a4e99ffef
-- New SHA: 42168dc339e1d919401bc1f2a3315807323372a1
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-make but no changes to version or port version.
-- Version: 2021-08-25
-- Old SHA: 2478c2e3dd12c98c88c7f405d585c86dc801198c
-- New SHA: be3d7001f8dd0c6e75b9a604c74f73edf4d202be
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a4c65c2f71c582a761bedb49c550b777926310c9 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/apr-util.json b/versions/a-/apr-util.json
index a2629d38..48d655e2 100644
--- a/versions/a-/apr-util.json
+++ b/versions/a-/apr-util.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6e039df30db545141c59425a585296777b110c7d",
+      "version-string": "1.6.1",
+      "port-version": 5
+    },
     {
       "git-tree": "cf1a0e97d00a5748dc58db7d0a5da0fd7d5efb66",
       "version-string": "1.6.1",
diff --git a/versions/a-/apr.json b/versions/a-/apr.json
index d652415a..c73d5fc3 100644
--- a/versions/a-/apr.json
+++ b/versions/a-/apr.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f3cb36f13b9cab10318f247494b23e5d2009f2ed",
+      "version": "1.7.0",
+      "port-version": 5
+    },
     {
       "git-tree": "b9e93acdaa680398eaed361f1df530096ded84ff",
       "version": "1.7.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index eb544b02..50dd9a92 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -106,11 +106,11 @@
     },
     "apr": {
       "baseline": "1.7.0",
-      "port-version": 4
+      "port-version": 5
     },
     "apr-util": {
       "baseline": "1.6.1",
-      "port-version": 4
+      "port-version": 5
     },
     "apsi": {
       "baseline": "0.3.1",
@@ -2338,7 +2338,7 @@
     },
     "gdal": {
       "baseline": "3.3.2",
-      "port-version": 1
+      "port-version": 2
     },
     "gdcm": {
       "baseline": "3.0.7",
@@ -2390,7 +2390,7 @@
     },
     "gettext": {
       "baseline": "0.21",
-      "port-version": 6
+      "port-version": 7
     },
     "gettimeofday": {
       "baseline": "2017-10-14",
@@ -2638,7 +2638,7 @@
     },
     "healpix": {
       "baseline": "1.12.10",
-      "port-version": 8
+      "port-version": 9
     },
     "hedley": {
       "baseline": "15",
@@ -2682,7 +2682,7 @@
     },
     "hunspell": {
       "baseline": "1.7.0",
-      "port-version": 5
+      "port-version": 6
     },
     "hwloc": {
       "baseline": "2.2.0",
@@ -3482,7 +3482,7 @@
     },
     "libiconv": {
       "baseline": "1.16",
-      "port-version": 11
+      "port-version": 12
     },
     "libics": {
       "baseline": "1.6.5",
@@ -3926,7 +3926,7 @@
     },
     "liburing": {
       "baseline": "2.0",
-      "port-version": 0
+      "port-version": 1
     },
     "libusb": {
       "baseline": "1.0.24",
@@ -4570,7 +4570,7 @@
     },
     "ncurses": {
       "baseline": "6.2",
-      "port-version": 1
+      "port-version": 2
     },
     "neargye-semver": {
       "baseline": "0.3.0",
diff --git a/versions/g-/gdal.json b/versions/g-/gdal.json
index af74f900..bcff6770 100644
--- a/versions/g-/gdal.json
+++ b/versions/g-/gdal.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0ba46f63f70a8d7ef1ff2253e48d4e45b0b0f629",
+      "version-semver": "3.3.2",
+      "port-version": 2
+    },
     {
       "git-tree": "6e90412cd51170a5ea63a0067005bb3afc3c6c36",
       "version-semver": "3.3.2",
diff --git a/versions/g-/gettext.json b/versions/g-/gettext.json
index adb7fea9..fbc69139 100644
--- a/versions/g-/gettext.json
+++ b/versions/g-/gettext.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d1eba48f67dbbd9a07b89b0850e1e42777a409b2",
+      "version": "0.21",
+      "port-version": 7
+    },
     {
       "git-tree": "72394a1e7b0ea6333d78849f864c4b7bc8c7e8dc",
       "version": "0.21",
diff --git a/versions/h-/healpix.json b/versions/h-/healpix.json
index a85f5293..87a3d636 100644
--- a/versions/h-/healpix.json
+++ b/versions/h-/healpix.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0eb7e3ec2016e2f927cb7c943f9434b5252366ec",
+      "version-string": "1.12.10",
+      "port-version": 9
+    },
     {
       "git-tree": "38bd9d397f3ba4e227f09a36ecb0af034f5f0c98",
       "version-string": "1.12.10",
diff --git a/versions/h-/hunspell.json b/versions/h-/hunspell.json
index af5756c9..c5b4354f 100644
--- a/versions/h-/hunspell.json
+++ b/versions/h-/hunspell.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3d6529e3845ea7ae9aadc6abeef30985d863e91e",
+      "version": "1.7.0",
+      "port-version": 6
+    },
     {
       "git-tree": "2a0514dd8b3893b6d3a502fbf55156e9e971d6f7",
       "version": "1.7.0",
diff --git a/versions/l-/libiconv.json b/versions/l-/libiconv.json
index 9423b271..7ecf38d5 100644
--- a/versions/l-/libiconv.json
+++ b/versions/l-/libiconv.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "534ed78492de209c5a752b53ef6567b61a577c3d",
+      "version": "1.16",
+      "port-version": 12
+    },
     {
       "git-tree": "f82980bff6c23bcccd043300679ebf8afa3e0a22",
       "version": "1.16",
diff --git a/versions/l-/liburing.json b/versions/l-/liburing.json
index 0ec46a4a..3cf5fcb9 100644
--- a/versions/l-/liburing.json
+++ b/versions/l-/liburing.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9eea2e30573c9bc095a193076d15896a98c6324d",
+      "version": "2.0",
+      "port-version": 1
+    },
     {
       "git-tree": "b4d90242721d15d6dc5287690c3b8d42c2e8d0f0",
       "version": "2.0",
diff --git a/versions/n-/ncurses.json b/versions/n-/ncurses.json
index 135f3c3b..1ef2b997 100644
--- a/versions/n-/ncurses.json
+++ b/versions/n-/ncurses.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "dcdfbaf6aaf3b24ac3c4c189b05d82c0f6954d90",
+      "version-string": "6.2",
+      "port-version": 2
+    },
     {
       "git-tree": "f196044f9f7779e0bdb54015dbd3be84aaa00820",
       "version-string": "6.2",
diff --git a/versions/x-/x264.json b/versions/x-/x264.json
index 793b3059..cae2f1f2 100644
--- a/versions/x-/x264.json
+++ b/versions/x-/x264.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "8146fd54bc8d5884cd76ec4139a1ea61ea23d3de",
+      "git-tree": "d95c7bd4f42aa5f0ce47b7e68fc8aad1de9566d7",
       "version-string": "157-303c484ec828ed0",
       "port-version": 17
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/apr-util/portfile.cmake
ports/apr/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/apr-util/portfile.cmake
ports/apr/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/apr-util/portfile.cmake
ports/apr/portfile.cmake

…jack/make_buildsystem

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 35443ee2753f46c52ac342fa6c9c48e9f5eb9105 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/g-/gdal.json b/versions/g-/gdal.json
index 49d2a5a3..9c935e60 100644
--- a/versions/g-/gdal.json
+++ b/versions/g-/gdal.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "0ba46f63f70a8d7ef1ff2253e48d4e45b0b0f629",
+      "git-tree": "61db9fdef0445baa95d39c2efa86c1c0fb828994",
       "version-semver": "3.3.2",
       "port-version": 3
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/apr-util/portfile.cmake
ports/apr/portfile.cmake

dg0yt · 2021-11-28T14:58:43Z

This PR hasn't seen team feedback in three weeks. What is the time frame for getting this finished? How to deal with improvements to the existing maintainer functions which still have dead code, redundant code, underused parallelization, and other deficencies?
Either this PR is finished quickly (with existing maintainer function behaviour as a starting point) so that changes can focus on the new port alone, or we will have to waste extra time on duplicating and merging changes.

JackBoosY · 2021-11-29T03:10:47Z

@dg0yt Sorry, I don't have much time, and I will handle this PR this week.

dg0yt · 2021-11-29T05:15:28Z

Okay, thanks.

For future maintainability:
vcpkg_configure_make and vcpkg_build_make cooperate by side effects and convention. Example: the name of the build directories.
Does it make sense to turn everything into explicit parameter passing?
Are any (environment) variables which are modified in the configure function allowed to have an effect on the build function?

JackBoosY · 2021-11-29T06:00:05Z

@dg0yt

Does it make sense to turn everything into explicit parameter passing?

For example?

Are any (environment) variables which are modified in the configure function allowed to have an effect on the build function?

For this one, I think we should follow vcpkg_*_make.

dg0yt · 2021-11-29T08:52:50Z

Does it make sense to turn everything into explicit parameter passing?

For example?

In the first place: the name of the build directory?

Are any (environment) variables which are modified in the configure function allowed to have an effect on the build function?

For this one, I think we should follow vcpkg_*_make.

ATM it is not obvious if vcpkg_configure_make resets all environment variables that it modifies, due to "code diversity". I need to know if not resetting some variables is intentional or a bug.

To combine both points, the make function duplicates some of the code of the configure function because things are not passed from one to another.

JackBoosY · 2022-02-23T06:02:13Z

Close this PR temporary.

JackBoosY added 2 commits August 26, 2021 01:48

Add vcpkg-make

d1266ad

Add depreciate message and check

206e29c

JackBoosY added info:internal This PR or Issue was filed by the vcpkg team. category:scripts-audit Part of the scripts audit effort. labels Aug 26, 2021

JackBoosY assigned PhoebeHui Aug 26, 2021

JackBoosY mentioned this pull request Aug 26, 2021

[scripts-audit] Work list for the scripts tree (stuff we don't need to do immediately) #16188

Open

github-actions bot requested changes Aug 26, 2021

View reviewed changes

JackBoosY mentioned this pull request Aug 26, 2021

[scripts-audit] Scripts tree auditing #17691

Closed

51 tasks

JackBoosY added 2 commits August 26, 2021 02:50

update doc

82f0375

version

657d28f

github-actions bot approved these changes Aug 26, 2021

View reviewed changes

JackBoosY added 3 commits August 29, 2021 23:11

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

fb75f09

…jack/make_buildsystem

Convert sample ports

56060fa

version

586c8c2

github-actions bot approved these changes Aug 30, 2021

View reviewed changes

Fix command line

f84f421

github-actions bot requested changes Aug 30, 2021

View reviewed changes

JackBoosY marked this pull request as ready for review September 1, 2021 07:12

Try to use MAKEFILE instead of subpath

bc3a0b9

github-actions bot requested changes Sep 1, 2021

View reviewed changes

Revert changes about SUBPATH

23ec7ec

github-actions bot requested changes Sep 2, 2021

View reviewed changes

JackBoosY added the info:world-rebuild label Sep 2, 2021

generate vcpkg-make docs

cf3127d

github-actions bot requested changes Sep 7, 2021

View reviewed changes

Update doc

825996a

github-actions bot requested changes Sep 7, 2021

View reviewed changes

Doc update

783c307

github-actions bot requested changes Sep 7, 2021

View reviewed changes

dg0yt reviewed Sep 7, 2021

View reviewed changes

github-actions bot requested changes Sep 17, 2021

View reviewed changes

update doc

27d1d42

github-actions bot requested changes Sep 17, 2021

View reviewed changes

This was referenced Sep 18, 2021

[scripts-audit] Make buildsystem #20165

Merged

[vcpkg] Always use an autotools build triplet #18130

Merged

JackBoosY added 2 commits October 22, 2021 00:12

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

7c3c5f9

…jack/make_buildsystem

Merge latest changes

23d5c0c

github-actions bot requested changes Oct 22, 2021

View reviewed changes

JackBoosY added 2 commits October 24, 2021 19:10

Revert some code, add port version

58aa6c4

version

038ffb4

JackBoosY marked this pull request as ready for review October 25, 2021 02:11

github-actions bot approved these changes Oct 25, 2021

View reviewed changes

Update docs

8e15dbb

github-actions bot approved these changes Oct 25, 2021

View reviewed changes

JackBoosY requested a review from strega-nil-ms October 26, 2021 00:20

JackBoosY added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 26, 2021

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

1c33052

…jack/make_buildsystem

github-actions bot requested changes Nov 2, 2021

View reviewed changes

strega-nil-ms changed the title ~~[scripts-audit] Make buildsystem~~ [scripts-audit] Make buildsystem (port) Nov 4, 2021

PhoebeHui marked this pull request as draft December 2, 2021 05:54

BillyONeal removed the info:world-rebuild label Feb 17, 2022

JackBoosY closed this Feb 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[scripts-audit] Make buildsystem (port) #19753

[scripts-audit] Make buildsystem (port) #19753

JackBoosY commented Aug 26, 2021 •

edited by PhoebeHui

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

dg0yt Sep 7, 2021

JackBoosY Sep 7, 2021 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

JackBoosY commented Sep 26, 2021

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

dg0yt commented Nov 28, 2021

JackBoosY commented Nov 29, 2021

dg0yt commented Nov 29, 2021

JackBoosY commented Nov 29, 2021

dg0yt commented Nov 29, 2021

JackBoosY commented Feb 23, 2022

[scripts-audit] Make buildsystem (port) #19753

[scripts-audit] Make buildsystem (port) #19753

Conversation

JackBoosY commented Aug 26, 2021 • edited by PhoebeHui Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

dg0yt Sep 7, 2021

Choose a reason for hiding this comment

JackBoosY Sep 7, 2021 • edited Loading

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Sep 26, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

dg0yt commented Nov 28, 2021

JackBoosY commented Nov 29, 2021

dg0yt commented Nov 29, 2021

JackBoosY commented Nov 29, 2021

dg0yt commented Nov 29, 2021

JackBoosY commented Feb 23, 2022

JackBoosY commented Aug 26, 2021 •

edited by PhoebeHui

Loading

JackBoosY Sep 7, 2021 •

edited

Loading