[scripts-audit] gn buildsystem #17776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command has never been used (git log -S"vcpkg_build_gn\("
gives no results outside of the file itself and docs)
and so shrink the public interface surface
strega-nil-ms
added
category:scripts-audit
51 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
|
@Neumann-A these scripts audits are not modifying the existing scripts' behavior at all; they don't add functionality, in order to allow me to actually get through all the scripts. To get new behavior, we'll need to do the ports script thing. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17776 in repo microsoft/vcpkg |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
strega-nil
commented
May 13, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #16188
This removes
vcpkg_gn_build(, since it's never been used and is just a pass-through tovcpkg_build_ninja((needs discussion, may end up being reverted). Additionally,vcpkg_gn_configureandvcpkg_gn_installare audited.