Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Upgrade GN dependency #17519

Closed
wants to merge 3 commits into from
Closed

Conversation

omartijn
Copy link
Contributor

Some packages cannot be upgraded without upgrading GN since they use
syntax introduced in later versions of GN. One such example is crashpad.

Describe the pull request

  • What does your PR fix?

Upgrades GN so packages using it can be upgraded

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No changes.

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Not applicable

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JackBoosY JackBoosY self-assigned this Apr 27, 2021
@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 27, 2021
@PhoebeHui PhoebeHui changed the title Upgrade GN dependency [vcpkg] Upgrade GN dependency May 7, 2021
@omartijn
Copy link
Contributor Author

Note: simage fails due to using deprecated type names exported from libtiff.
See http://www.simplesystems.org/libtiff/v4.3.0.html

These build failures have nothing to do with this PR, but are introduced when the libtiff port was updated to 4.3.0.

@dg0yt
Copy link
Contributor

dg0yt commented Jun 18, 2021

Note: simage fails due to using deprecated type names exported from libtiff.
See http://www.simplesystems.org/libtiff/v4.3.0.html

These build failures have nothing to do with this PR, but are introduced when the libtiff port was updated to 4.3.0.

These build failures have nothing to do with this PR, but also aren't an issue of port tiff:
simage for windows triplets does not depend on tiff (and some other ports) so it must not use them. That's why it was not covered in CI for port tiff.

@omartijn
Copy link
Contributor Author

These build failures have nothing to do with this PR, but also aren't an issue of port tiff:
simage for windows triplets does not depend on tiff (and some other ports) so it is no must not use them. That's why it was not covered in CI for port tiff.

And yet the error messages clearly indicate they're happening due to using deprecated symbols from libtiff:

4>D:\buildtrees\simage\src\mage-1.8.0-17f988a113.clean\src\simage_tiff.c(88,18): error C4996: 'uint16': libtiff type deprecated; please use corresponding C99 stdint.h type [D:\buildtrees\simage\arm-uwp-dbg\simage.vcxproj]

So it seems there is a combination of issues:

  • for whatever reason vcpkg pulls in an incorrect dependency
  • the simage library is misconfigured to use it
  • simage is outdated and should probably be fixed
  • deprecations are treated as errors

@omartijn omartijn force-pushed the upgrade-gn branch 2 times, most recently from 91e4437 to 2ae561c Compare June 24, 2021 07:03
@JackBoosY
Copy link
Contributor

Any progress here?
We wish to replace vcpkg_*_gn with vcpkg_*_ninja in the future.

@omartijn
Copy link
Contributor Author

No progress, unfortunately. As you might see from the CI, any change here seems to fail some unrelated packages. I haven't had the time to figure this out. If you want to get rid of all the vcpkg_*_gn functions, I'd say go for it, though how you plan to do this, I don't know. AFAIK many google projects don't come with Ninja files, but you have to first use gn to generate the ninja files.

@JackBoosY
Copy link
Contributor

JackBoosY commented Sep 10, 2021

Most of the regressions are unrelated, we just need to focus on the v8 one.

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

When building chromium-base:x64-windows-static:

ERROR at //build/config/BUILDCONFIG.gn:401:1: Unknown function.
set_sources_assignment_filter(sources_assignment_filter)
^----------------------------

@JackBoosY
Copy link
Contributor

Please get failure logs here.

@JackBoosY
Copy link
Contributor

Ping for response.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for skia but no changes to version or port version.
-- Version: 2020-05-18#7
-- Old SHA: f7b3961a52ea4c43d781a5c8ace67d0ef100cce7
-- New SHA: 03c775722ac220b99abdac7466739fa4381a169c
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/skia/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/v8/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JackBoosY
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@JackBoosY JackBoosY closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants