-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Upgrade GN dependency #17519
Conversation
Note: simage fails due to using deprecated type names exported from libtiff. These build failures have nothing to do with this PR, but are introduced when the libtiff port was updated to 4.3.0. |
These build failures have nothing to do with this PR, but also aren't an issue of port tiff: |
And yet the error messages clearly indicate they're happening due to using deprecated symbols from libtiff:
So it seems there is a combination of issues:
|
91e4437
to
2ae561c
Compare
Any progress here? |
No progress, unfortunately. As you might see from the CI, any change here seems to fail some unrelated packages. I haven't had the time to figure this out. If you want to get rid of all the |
Most of the regressions are unrelated, we just need to focus on the |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
When building
|
Please get failure logs here. |
Ping for response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for skia but no changes to version or port version.
-- Version: 2020-05-18#7
-- Old SHA: f7b3961a52ea4c43d781a5c8ace67d0ef100cce7
-- New SHA: 03c775722ac220b99abdac7466739fa4381a169c
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/skia/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/v8/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
Some packages cannot be upgraded without upgrading GN since they use
syntax introduced in later versions of GN. One such example is crashpad.
Describe the pull request
What does your PR fix?
Upgrades GN so packages using it can be upgraded
Which triplets are supported/not supported? Have you updated the CI baseline?
No changes.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Not applicable
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/