[vtk] fix find lz4 hdf5 pegl #15521

dweckmann · 2021-01-08T08:34:08Z

Describe the pull request

What does your PR fix? Fixes VTK - ITK - HDF5 Conflicts and are unusable together #15502

Basically it fixes LZ4, HDF5, PEGL import problems, allowing to use VTK / ITK with FindPackage.

ports/vtk/FindHDF5.cmake

JackBoosY · 2021-01-12T02:33:04Z

Please ping me if this PR is ready for review.

dweckmann · 2021-01-12T05:34:47Z

Please ping me if this PR is ready for review.

unfortunately not yet. I didn't manage to fix correctly the initial problem (hdf5 double inclusion when using VTK + ITK)

WangZP10969 · 2021-01-12T07:55:03Z

Please ping me if this PR is ready for review.

unfortunately not yet. I didn't manage to fix correctly the initial problem (hdf5 double inclusion when using VTK + ITK)

For users who only use vtk, do you have any way to deal with this problem? I tried your changes, for the modification of lz4, the compilation did not report an error, but for hdf5 pegl did not seem to solve the problem.

dweckmann · 2021-01-12T08:19:18Z

Please ping me if this PR is ready for review.

unfortunately not yet. I didn't manage to fix correctly the initial problem (hdf5 double inclusion when using VTK + ITK)

For users who only use vtk, do you have any way to deal with this problem? I tried your changes, for the modification of lz4, the compilation did not report an error, but for hdf5 pegl did not seem to solve the problem.

Well, I removed the hdf5 patch as it breaks VTK build (as you noticed). I've tried many things with no acceptable solutions. I'm trying to remove the FindHDF5.cmake after build as a workaround for now...

If any of you have an idea, I'm taking it.

dweckmann · 2021-01-15T10:26:19Z

I didn't manage to fix the issue with hdf5. So I propose this workaround (simply removing FindHDF5.cmake after build from VTK and use the regular config from HDF5 directly), which seems to be effective for us.

If anyone have a better solution, I'll take it.

JackBoosY · 2021-01-18T06:39:36Z

Since you've closed the modify permission of other mantainers, please do the following steps:

update this branch from vcpkg master
rebuild vcpkg
use command ./vcpkg x-add-version --all
commit changes

WangZP10969 · 2021-01-19T03:30:18Z

@dweckmann Thank you very much for your contribution！
I tried your changes, I can successfully configure the VTK library.

During the test, a problem was found.
Normally, the library is only searched once, but in my development, the library is searched again in the subdirectory (due to design issues).

For other libraries, there is no problem with repeated search:
find_package(Qt5 REQUIRED Widgets)
find_package(Qt5 REQUIRED Widgets)

For the VTK library, an error message will be reported for repeated searches:
find_package(VTK REQUIRED)
find_package(VTK REQUIRED)

Searching for PEGTL Searching for PEGTL - found target taocpp::pegtl CMake Error at libwvl/3rdParty/scripts/buildsystems/vcpkg.cmake:489 (_add_library): _add_library cannot create imported target "PEGTL::PEGTL" because another target with the same name already exists. Call Stack (most recent call first): libwvl/3rdParty/installed/x64-windows/share/vtk/FindPEGTL.cmake:26 (add_library) libwvl/3rdParty/scripts/buildsystems/vcpkg.cmake:634 (_find_package) libwvl/3rdParty/installed/x64-windows/share/vtk/VTK-vtk-module-find-packages.cmake:585 (find_package) libwvl/3rdParty/installed/x64-windows/share/vtk/vtk-config.cmake:129 (include) libwvl/3rdParty/scripts/buildsystems/vcpkg.cmake:634 (_find_package) CMakeLists.txt:14 (find_package)

Do you have any suggestions for this situation? If finding the library twice is indeed abnormal behavior, I will try to adjust the project logic to solve it.

dweckmann · 2021-01-19T05:32:25Z

Do you have any suggestions for this situation? If finding the library twice is indeed abnormal behavior, I will try to adjust the project logic to solve it.

No sorry, VTK cmake files are too complex for my basic knowledge about it. I've tried to tweak a bit this part, but either my project won't build, either VTK won't.

Neumann-A · 2021-01-19T07:57:43Z

Do you have any suggestions for this situation? If finding the library twice is indeed abnormal behavior, I will try to adjust the project logic to solve it.

All find modules should have a check if(NOT TARGET <targetname>) and only create the target if it does not exists. Maybe that is missing here

ports/vtk/pegtl.patch

port_versions/v-/vtk.json

JackBoosY

Please bump the port version. See documentation.

And do the following steps:

Revert changes a bout port_versions/v-/vtk.json
Rerun command ./vcpkg x-add-version vtk
Update changes

strega-nil · 2021-01-21T19:13:35Z

Same for this one, you'll have to rebase on upstream/master.

JackBoosY · 2021-01-22T09:22:11Z

LGTM, @Neumann-A do you have any other questions?

BillyONeal

You need to:

Merge with origin/master. Take master's versions/v-/vtk.json
Bump Port-Version in ports/vtk/CONTROL
Commit that
vcpkg x-add-version vtk
Commit that

I tried to do this for you but you didn't allow maintainer edits when creating the pr.

BillyONeal · 2021-04-29T00:48:59Z

versions/v-/vtk.json

-{
-  "versions": [
-    {
-      "git-tree": "88d95daae73bf5c3413bb18188c81f9ea752e418",


You need to not damage the existing versions database.

It should be good now. Thanks for your time !

BillyONeal · 2021-04-29T17:26:33Z

/azp run

azure-pipelines · 2021-04-29T17:26:43Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2021-04-29T17:26:45Z

(Rerunning due to replacing the macos vms)

JackBoosY · 2021-04-30T09:33:56Z

Please add add paraview:x64-windows-static-md=fail to scripts\ci.baseline.txt.
The qt executable run failed, not related to this PR:

[8196/8526] cmd.exe /C "cd /D D:\buildtrees\paraview\x64-windows-static-md-dbg\Qt\ApplicationComponents && D:\downloads\tools\cmake-3.20.1-windows\cmake-3.20.1-windows-i386\bin\cmake.exe -E cmake_autogen D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents/CMakeFiles/pqApplicationComponents_autogen.dir/AutogenInfo.json Debug && D:\downloads\tools\cmake-3.20.1-windows\cmake-3.20.1-windows-i386\bin\cmake.exe -E touch D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents/pqApplicationComponents_autogen/timestamp && D:\downloads\tools\cmake-3.20.1-windows\cmake-3.20.1-windows-i386\bin\cmake.exe -E cmake_transform_depfile Ninja gccdepfile D:/buildtrees/paraview/src/4fb6e6800f-6b3165e6c7.clean D:/buildtrees/paraview/src/4fb6e6800f-6b3165e6c7.clean/Qt/ApplicationComponents D:/buildtrees/paraview/x64-windows-static-md-dbg D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents/pqApplicationComponents_autogen/deps D:/buildtrees/paraview/x64-windows-static-md-dbg/CMakeFiles/d/630ac66b060be7d2f120939a329ec87fdb66a012132616509ba12948a0087196.d"
FAILED: Qt/ApplicationComponents/pqApplicationComponents_autogen/timestamp 
cmd.exe /C "cd /D D:\buildtrees\paraview\x64-windows-static-md-dbg\Qt\ApplicationComponents && D:\downloads\tools\cmake-3.20.1-windows\cmake-3.20.1-windows-i386\bin\cmake.exe -E cmake_autogen D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents/CMakeFiles/pqApplicationComponents_autogen.dir/AutogenInfo.json Debug && D:\downloads\tools\cmake-3.20.1-windows\cmake-3.20.1-windows-i386\bin\cmake.exe -E touch D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents/pqApplicationComponents_autogen/timestamp && D:\downloads\tools\cmake-3.20.1-windows\cmake-3.20.1-windows-i386\bin\cmake.exe -E cmake_transform_depfile Ninja gccdepfile D:/buildtrees/paraview/src/4fb6e6800f-6b3165e6c7.clean D:/buildtrees/paraview/src/4fb6e6800f-6b3165e6c7.clean/Qt/ApplicationComponents D:/buildtrees/paraview/x64-windows-static-md-dbg D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents D:/buildtrees/paraview/x64-windows-static-md-dbg/Qt/ApplicationComponents/pqApplicationComponents_autogen/deps D:/buildtrees/paraview/x64-windows-static-md-dbg/CMakeFiles/d/630ac66b060be7d2f120939a329ec87fdb66a012132616509ba12948a0087196.d"

Neumann-A · 2021-04-30T09:44:25Z

Please add add paraview:x64-windows-static-md=fail to scripts\ci.baseline.txt.
The qt executable run failed, not related to this PR:

@JackBoosY: Why? This looks like the same issue marble had in another PR. Maybe there is some issue with the newer CMake version?

JackBoosY · 2021-04-30T09:48:37Z

@Neumann-A So can you make a new PR to fix that?

JackBoosY · 2021-09-10T06:47:47Z

Can you please merge to master?

JackBoosY · 2021-09-30T06:13:05Z

Ping @dweckmann for response.

dweckmann · 2021-09-30T19:20:38Z

Ping @dweckmann for response.

Sorry, I don't have time to spend on this anymore as we are focused on other subjects right now. I really wish I could help further, but I cannot make any promise, sorry again. Feel free to close the PR or re-author it.

JackBoosY · 2021-10-08T01:19:04Z

Okay, please continue your PR in any time.

JackBoosY · 2022-01-06T16:43:43Z

If you want to continue this PR, please reopen.

FrankXie05 · 2022-01-28T10:12:16Z

@dweckmann Is still work for this PR? Please reply me

dweckmann · 2022-01-28T10:39:58Z

@dweckmann Is still work for this PR? Please reply me

@FrankXie05 The last time I checked, only the patch for lz4 in VTK is still relevant. I guess you have to strip all other patches and only keep that.

Feel free to take this pr as basis and reopen.

FrankXie05 · 2022-01-28T10:43:52Z

@dweckmann Thanks for your reply, I will submit a PR to verify it. :)

Neumann-A reviewed Jan 8, 2021

View reviewed changes

ports/vtk/FindHDF5.cmake Outdated Show resolved Hide resolved

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch 3 times, most recently from 983b362 to 8d7f6bc Compare January 8, 2021 16:30

JackBoosY self-assigned this Jan 11, 2021

JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 11, 2021

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch 2 times, most recently from 48c7c8e to 9f90402 Compare January 11, 2021 10:57

dweckmann marked this pull request as ready for review January 15, 2021 10:26

JackBoosY added the requires:author-response label Jan 18, 2021

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch from f62f36d to 84eadab Compare January 19, 2021 05:28

Neumann-A reviewed Jan 19, 2021

View reviewed changes

ports/vtk/pegtl.patch Outdated Show resolved Hide resolved

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch from e722fb2 to 6266124 Compare January 20, 2021 07:10

JackBoosY suggested changes Jan 21, 2021

View reviewed changes

port_versions/v-/vtk.json Outdated Show resolved Hide resolved

JackBoosY suggested changes Jan 21, 2021

View reviewed changes

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch from d1153fc to 4922629 Compare January 21, 2021 07:52

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch 2 times, most recently from a7f3589 to d97e800 Compare January 22, 2021 09:07

JackBoosY approved these changes Jan 22, 2021

View reviewed changes

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Feb 1, 2021

PhoebeHui changed the title ~~Vtk fix find lz4 hdf5 pegl~~ [vtk] fix find lz4 hdf5 pegl Feb 2, 2021

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch from de5fa33 to 1cf88f8 Compare February 2, 2021 16:11

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch from 1cf88f8 to 3fc3f01 Compare March 1, 2021 08:33

fbridault force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch from 3fc3f01 to d249393 Compare April 7, 2021 06:57

BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 29, 2021

BillyONeal reviewed Apr 29, 2021

View reviewed changes

[vtk] fix find lz4 hdf5 pegl (microsoft#15521)

9b60e12

dweckmann force-pushed the vtk-fix-find-lz4-hdf5-PEGL branch from d249393 to 9b60e12 Compare April 29, 2021 13:53

BillyONeal removed the requires:author-response label Apr 29, 2021

JackBoosY added the requires:author-response label Apr 30, 2021

JackBoosY removed the requires:author-response label Sep 10, 2021

JackBoosY marked this pull request as draft October 8, 2021 01:18

JackBoosY closed this Jan 6, 2022

dweckmann deleted the vtk-fix-find-lz4-hdf5-PEGL branch July 21, 2023 05:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vtk] fix find lz4 hdf5 pegl #15521

[vtk] fix find lz4 hdf5 pegl #15521

dweckmann commented Jan 8, 2021

JackBoosY commented Jan 12, 2021

dweckmann commented Jan 12, 2021

WangZP10969 commented Jan 12, 2021

dweckmann commented Jan 12, 2021

dweckmann commented Jan 15, 2021

JackBoosY commented Jan 18, 2021 •

edited

Loading

WangZP10969 commented Jan 19, 2021 •

edited

Loading

dweckmann commented Jan 19, 2021

Neumann-A commented Jan 19, 2021 •

edited

Loading

JackBoosY left a comment

strega-nil commented Jan 21, 2021

JackBoosY commented Jan 22, 2021

BillyONeal left a comment

BillyONeal Apr 29, 2021

dweckmann Apr 29, 2021

BillyONeal commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

BillyONeal commented Apr 29, 2021

JackBoosY commented Apr 30, 2021 •

edited

Loading

Neumann-A commented Apr 30, 2021

JackBoosY commented Apr 30, 2021

JackBoosY commented Sep 10, 2021

JackBoosY commented Sep 30, 2021

dweckmann commented Sep 30, 2021

JackBoosY commented Oct 8, 2021

JackBoosY commented Jan 6, 2022

FrankXie05 commented Jan 28, 2022

dweckmann commented Jan 28, 2022 •

edited

Loading

FrankXie05 commented Jan 28, 2022

[vtk] fix find lz4 hdf5 pegl #15521

[vtk] fix find lz4 hdf5 pegl #15521

Conversation

dweckmann commented Jan 8, 2021

JackBoosY commented Jan 12, 2021

dweckmann commented Jan 12, 2021

WangZP10969 commented Jan 12, 2021

dweckmann commented Jan 12, 2021

dweckmann commented Jan 15, 2021

JackBoosY commented Jan 18, 2021 • edited Loading

WangZP10969 commented Jan 19, 2021 • edited Loading

dweckmann commented Jan 19, 2021

Neumann-A commented Jan 19, 2021 • edited Loading

JackBoosY left a comment

Choose a reason for hiding this comment

strega-nil commented Jan 21, 2021

JackBoosY commented Jan 22, 2021

BillyONeal left a comment

Choose a reason for hiding this comment

BillyONeal Apr 29, 2021

Choose a reason for hiding this comment

dweckmann Apr 29, 2021

Choose a reason for hiding this comment

BillyONeal commented Apr 29, 2021

azure-pipelines bot commented Apr 29, 2021

BillyONeal commented Apr 29, 2021

JackBoosY commented Apr 30, 2021 • edited Loading

Neumann-A commented Apr 30, 2021

JackBoosY commented Apr 30, 2021

JackBoosY commented Sep 10, 2021

JackBoosY commented Sep 30, 2021

dweckmann commented Sep 30, 2021

JackBoosY commented Oct 8, 2021

JackBoosY commented Jan 6, 2022

FrankXie05 commented Jan 28, 2022

dweckmann commented Jan 28, 2022 • edited Loading

FrankXie05 commented Jan 28, 2022

JackBoosY commented Jan 18, 2021 •

edited

Loading

WangZP10969 commented Jan 19, 2021 •

edited

Loading

Neumann-A commented Jan 19, 2021 •

edited

Loading

JackBoosY commented Apr 30, 2021 •

edited

Loading

dweckmann commented Jan 28, 2022 •

edited

Loading