-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imgui] Add Freetype feature #11919
[imgui] Add Freetype feature #11919
Conversation
I'd also like to suggest to remove or at least split the bindings feature. Imgui bindings are not really part of the library, and including them all in the same feature require many dependencies to be fetched, which is probably overkill in most cases. Also copying cpp files to the include folder should be avoided. |
Thanks for the PR! |
I'm not familiar with I think having them as a non-default feature is good enough, some ports already have "examples" features that do the same. |
These bindings are very well maintained, feature complete and the author recommend to use them by default except if a custom implementation is really needed : https://github.com/ocornut/imgui#integration I think it's a good thing they are available as features for this port. What I dislike is the inability to pick only the required ones, it's all or nothing. Because of this, you are forced to acquire a lot of dependencies you will probably never need. It's also ugly because it isn't compiled to libs but rely instead on the manual inclusion of cpp files in your project, because some of them depends on platform specific APIs that can't be compiled everywhere. Splitting these bindings to different features would solve these problems. The only drawback is that we would have a very long list of features :
I don't know if it's acceptable for vcpkg ports to have such a long feature list, but if it is, it would be a better solution than the current one, and I'd be happy to add it. |
* [implot] Initial port Requires #11919 * [implot] Use find_package instead of find_path function * [implot] Update to 0.3 version * Update CONTROL * [implot] Add linkage check * Update CMakeLists.txt * Revert 962e30a * [implot] Fix INSTALL_INTERFACE path case and use find_package Config mode Co-authored-by: Lily <47812810+LilyWangL@users.noreply.github.com>
-Add Freetype feature, which use Freetype instead of stb_truetype to build the font atlases (https://github.com/ocornut/imgui/tree/master/misc/freetype).
-Add imgui_internal.h to public includes, because it is required to use the experimental API and improve debug capabilities. It's also required to build Implot (#11920).
-Add imgui_stdlib files to allow std::string usage with Imgui text functions (ocornut/imgui#2035).
-Fix bindings feature requiring SDL1 dependency instead of SDL2 (Imgui SDL binding is using the latter).