Delete --x-use-aria2. #1582
Merged
Delete --x-use-aria2. #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Huge parts of the vcpkg product do not respect this setting * microsoft/vcpkg#30079 shows it has been entirely broken for an extremely long time. * It's an --x switch and we never claimed full support for it. * We have never tested that it ever actually works. Related: microsoft/vcpkg-docs#441
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jan 23, 2025
JavierMatosD
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be OK to bring this back someday by teaching
x-downloadand friends to use it directly, but given how long it's been broken and ~2 people noticed or cared, that doesn't seem worth it.Users also have available workarounds if they've arranged aria2c to be present already with the
x-scriptasset caching mechanism as a last resort.Related: microsoft/vcpkg-docs#441