Apply the normal "to_string" pattern in more places. #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas1664
reviewed
Oct 22, 2024
Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>
ras0219-msft
approved these changes
Oct 23, 2024
| @@ -18,3 +18,11 @@ VCPKG_MSVC_WARNING(disable : 6239 4702) | |||
| #include <fmt/format.h> | |||
| #include <fmt/ranges.h> | |||
| VCPKG_MSVC_WARNING(pop) | |||
|
|
|||
| template<class T> | |||
| std::string adapt_to_string(const T& val) | |||
There was a problem hiding this comment.
Should this be a constexpr functor object?
constexpr struct AdaptToString
{
template<class T>
std::string operator()(const T& val) {
std::string result;
val.to_string(result);
return result;
}
} adapt_to_string;There was a problem hiding this comment.
I don't believe anything else would want the name adapt_to_string to require such ADL defenses?
There was a problem hiding this comment.
Or, to put this another way: Maybe. To accomplish what?
There was a problem hiding this comment.
To make it "better" when used in functional style like .map(adapt_to_string)
| @@ -9,11 +9,13 @@ namespace vcpkg | |||
|
|
|||
| void serialize(const StatusParagraph& pgh, std::string& out_str) | |||
| { | |||
| auto want_literal = to_string_literal(pgh.want); | |||
| auto state_literal = to_string_literal(pgh.state); | |||
| serialize(pgh.package, out_str); | |||
| out_str.append("Status: ") | |||
There was a problem hiding this comment.
Suggested change
| out_str.append("Status: ") | |
| Strings::append(out_str, "Status: ", want_literal, " ok ", state_literal, "\n"); |
There was a problem hiding this comment.
I don't want to do this because in #1514 I replaced all of this with the normal 'the way we write paragraph fields' function.
There was a problem hiding this comment.
append_paragraph_field(ParagraphIdStatus, pgh.status.to_string(), out);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1514