Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@typespec/spector] Update start server scenario paths #5309

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

sarangan12
Copy link
Contributor

With my earlier PRs, I have already moved all the scenarioPath parameters to scenarioPaths parameter i.e. made that parameter from a single value to an array of values.

But, this start script was missed earlier. But, the Go SDK generator uses this script and need this to be updated. This PR acoomplishes that.

Please review and approve this PR. Thanks

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 9, 2024

All changed packages have been documented.

  • @typespec/spec-coverage-sdk
  • @typespec/spector
Show changes

@typespec/spector - internal ✏️

Update server start script parameter - scenarioPath to scenarioPaths.

@typespec/spec-coverage-sdk - internal ✏️

Added packageName property to metadata

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Expect approval from experts.

@sarangan12 sarangan12 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into microsoft:main with commit 2a03294 Dec 10, 2024
23 checks passed
@sarangan12 sarangan12 deleted the UpdateStartServerScenarioPaths branch December 10, 2024 18:14
archerzz pushed a commit to archerzz/typespec that referenced this pull request Dec 17, 2024
With my earlier PRs, I have already moved all the `scenarioPath`
parameters to `scenarioPaths` parameter i.e. made that parameter from a
single value to an array of values.

But, this start script was missed earlier. But, the Go SDK generator
uses this script and need this to be updated. This PR acoomplishes that.

Please review and approve this PR. Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants