-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@typespec/spector] Update start server scenario paths #5309
Merged
sarangan12
merged 8 commits into
microsoft:main
from
sarangan12:UpdateStartServerScenarioPaths
Dec 10, 2024
Merged
[@typespec/spector] Update start server scenario paths #5309
sarangan12
merged 8 commits into
microsoft:main
from
sarangan12:UpdateStartServerScenarioPaths
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
December 9, 2024 19:07
You can try these changes here
|
weidongxu-microsoft
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Expect approval from experts.
archerzz
pushed a commit
to archerzz/typespec
that referenced
this pull request
Dec 17, 2024
With my earlier PRs, I have already moved all the `scenarioPath` parameters to `scenarioPaths` parameter i.e. made that parameter from a single value to an array of values. But, this start script was missed earlier. But, the Go SDK generator uses this script and need this to be updated. This PR acoomplishes that. Please review and approve this PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my earlier PRs, I have already moved all the
scenarioPath
parameters toscenarioPaths
parameter i.e. made that parameter from a single value to an array of values.But, this start script was missed earlier. But, the Go SDK generator uses this script and need this to be updated. This PR acoomplishes that.
Please review and approve this PR. Thanks