Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-client-csharp] Make RequestOptions parameter optional in protocol methods #5018

Merged

Conversation

jorgerangel-msft
Copy link
Contributor

@jorgerangel-msft jorgerangel-msft commented Nov 7, 2024

fixes: #4990

contributes to #4903

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 7, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jorgerangel-msft jorgerangel-msft marked this pull request as ready for review November 7, 2024 21:45
@jorgerangel-msft jorgerangel-msft added this pull request to the merge queue Nov 7, 2024
Merged via the queue into microsoft:main with commit 910ca35 Nov 7, 2024
21 checks passed
@jorgerangel-msft jorgerangel-msft deleted the fix-requestoptions-param branch November 7, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAI - RequestOptions options param should be optional in protocol methods
3 participants