Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typespec Generation for Empty Schema #4923 #4934

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Typespec Generation for Empty Schema #4923 #4934

merged 5 commits into from
Nov 1, 2024

Conversation

JamesChen-us
Copy link
Contributor

fix #4923

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:openapi3 Issues for @typespec/openapi3 emitter label Oct 31, 2024
@JamesChen-us
Copy link
Contributor Author

@JamesChen-us please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@JamesChen-us
Copy link
Contributor Author

@microsoft-github-policy-service agree

chrisradek
chrisradek reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesChen-us Thank you for creating this pull request and addressing the CI failures! I just had one minor comment on the changelog notes, but otherwise think this looks great!

.chronus/changes/fix-open-api-empty-schema-2024-10-1-6-50-22.md Outdated Show resolved Hide resolved
@chrisradek chrisradek added this pull request to the merge queue Nov 1, 2024
@chrisradek
Copy link
Member

@JamesChen-us Thank you again for your contribution! Merging this now - this will be included in the next release!

Merged via the queue into microsoft:main with commit b47d039 Nov 1, 2024
18 checks passed
swatkatz pushed a commit to swatkatz/typespec that referenced this pull request Nov 5, 2024
@JamesChen-us @chrisradek
Typespec Generation for Empty Schema microsoft#4923 (microsoft#4934)
b8b8c8c 
fix microsoft#4923

---------

Co-authored-by: Christopher Radek <14189820+chrisradek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
emitter:openapi3 Issues for @typespec/openapi3 emitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAPI3 Converted produce invalid typespec for empty schema
2 participants
@JamesChen-us @chrisradek