[@typespec/spector] - Handle and report failed scenarios at the end #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
|
|
You can try these changes here
|
timotheeguerin
approved these changes
Oct 25, 2024
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
…icrosoft#4872) In the `server-test` scenario, if there is an error, then the script immediately reports the error and comes out of the execution. But, the service generator has not implemented all the scenarios yet. So, If all the scenarios are executed, then the script might fail even before executing the intended script. So, the correct approach would be to report at the end. Please review and approve the PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
server-testscenario, if there is an error, then the script immediately reports the error and comes out of the execution. But, the service generator has not implemented all the scenarios yet. So, If all the scenarios are executed, then the script might fail even before executing the intended script. So, the correct approach would be to report at the end.Please review and approve the PR. Thanks