Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vs-code-extension] add basic snippets for typespec #4737

Merged
merged 11 commits into from
Oct 23, 2024
Merged

[vs-code-extension] add basic snippets for typespec #4737

merged 11 commits into from
Oct 23, 2024

Conversation

archerzz
Copy link
Member

  • add snippets for typespec basic constructs
  • package snippets within vs code extension

part of #4559

@archerzz
feat(vscode): add basic snippets for typespec
5d4dd91 
- add snippets for typespec basic constructs
- package snippets within vs code extension

part of microsoft#4559
@archerzz archerzz requested a review from RodgeFu October 15, 2024 03:00
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 15, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ typespec-vscode
Show changes

typespec-vscode - feature ✏️

Add basic snippets for typespec

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@microsoft-github-policy-service microsoft-github-policy-service bot added the ide Issues for VS, VSCode, Monaco, etc. label Oct 15, 2024
@archerzz archerzz changed the title feat(vscode): add basic snippets for typespec [vs-code-extension] add basic snippets for typespec Oct 16, 2024
@archerzz
change accorinding to review comments
95873a9 
- simplify some placeholder names
- use lower case for first letter of placeholder names
- replace some placeholders with `$TM_SELECTED_TEXT$0` to just move the cursor
- add `${3:type}` for operation
@archerzz
delete Alias snippet which is too simple
7a81cc0
@archerzz
fix wrong operation key word
02a7d7e
@archerzz
Merge branch 'main' into vs-code-extension/typespec-snippets
d20d38d
@archerzz
Copy link
Member Author

Summary of the changes:

  • fix wrong operation keyword
  • delete Alias snippet which is too simple
  • simplify some placeholder names
  • use lower case for first letter of placeholder names
  • replace some placeholders with $TM_SELECTED_TEXT$0 to just move the cursor
  • add ${3:type} for operation

reference: https://github.com/microsoft/vscode/blob/main/extensions/typescript-basics/snippets/typescript.code-snippets?rgh-link-date=2024-10-21T07%3A05%3A26Z

@archerzz archerzz marked this pull request as ready for review October 22, 2024 08:15
@archerzz archerzz added this pull request to the merge queue Oct 23, 2024
Merged via the queue into microsoft:main with commit ca2d301 Oct 23, 2024
22 checks passed
@archerzz archerzz deleted the vs-code-extension/typespec-snippets branch October 23, 2024 04:22
swatkatz pushed a commit to swatkatz/typespec that referenced this pull request Nov 5, 2024
@archerzz
[vs-code-extension] add basic snippets for typespec (microsoft#4737)
2f3e91e 
- add snippets for typespec basic constructs
- package snippets within vs code extension

part of microsoft#4559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodgeFu RodgeFu RodgeFu left review comments

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@archerzz @azure-sdk @timotheeguerin @RodgeFu