Don't generate prop if custom prop exists in base #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check API changes are not detected in this pull request. |
jorgerangel-msft
force-pushed
the
duplicate-custom-prop
branch
from
fe35198 to
312ffef
Compare
jorgerangel-msft
requested review from
m-nash and
JoshLove-msft
as code owners
jorgerangel-msft
requested review from
jsquire,
ShivangiReja and
nisha-bhatia
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs
Outdated
Show resolved
Hide resolved
…licate-custom-prop
JoshLove-msft
approved these changes
Oct 11, 2024
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
This PR address the following bugs: - If a model contains a spec property that was also added as a custom model in it's base model, the derived model will not generate the property. - if a custom property is added to a base model and it includes the `CodeGenSerialization` attribute, that property is included in serialization ctor for the derived model. fixes: microsoft#4629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the following bugs:
CodeGenSerializationattribute, that property is included in serialization ctor for the derived model.fixes: #4629