java generator, support non-string expandable enum for TypeSpec #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code fix typespec fix
microsoft-github-policy-service
bot
added
the
emitter:client:java
XiaofeiCao
changed the title
XiaofeiCao
commented
Sep 23, 2024
...-generator-test/src/main/java/com/type/model/inheritance/enumdiscriminator/models/Snake.java
Show resolved
Hide resolved
|
No changes needing a change description found. |
|
You can try these changes here
|
|
I am not sure about Swagger non-string expansive enum. I am kind of inclined for them to use ExpandableEnum as well. But I don't know what they really are in service backend. |
...ore/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/SchemaMapper.java
Outdated
Show resolved
Hide resolved
.../main/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/EnumType.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/microsoft/typespec/http/client/generator/mgmt/mapper/FluentChoiceMapper.java
Outdated
Show resolved
Hide resolved
Yes, it depends on backend. Let me do a summary and bring this up on thursday's meeting. |
...rc/main/java/com/microsoft/typespec/http/client/generator/template/TypeSpecEnumTemplate.java
Outdated
Show resolved
Hide resolved
...p-client-generator-test/src/main/java/com/cadl/armresourceprovider/models/PriorityModel.java
Outdated
Show resolved
Hide resolved
...p-client-generator-test/src/main/java/com/cadl/armresourceprovider/models/PriorityModel.java
Outdated
Show resolved
Hide resolved
...p-client-generator-test/src/main/java/com/cadl/armresourceprovider/models/PriorityModel.java
Outdated
Show resolved
Hide resolved
...p-client-generator-test/src/main/java/com/cadl/armresourceprovider/models/PriorityModel.java
Outdated
Show resolved
Hide resolved
...-generator-test/src/main/java/com/type/model/inheritance/enumdiscriminator/models/Snake.java
Show resolved
Hide resolved
srnagar
approved these changes
Oct 9, 2024
...ore/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/SchemaMapper.java
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Oct 10, 2024
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
…osoft#4492) ## Previous non-string expandable enum implementation - Branded - Swagger(ExpandableStringEnum, serialization having trouble) - TypeSpec(ExpandableStringEnum, serialization having trouble) - Unbranded - ExpandableEnum interface ## After this PR - Branded - Swagger(ExpandableEnum interface implementation, with serialization/deserialization supported) - TypeSpec(ExpandableEnum interface implementation, with serialization/deserialization supported) - Unbranded(untouched, supported) ## Limitations - Only supports string and number extensible enums. - Current TypeSpec doesn't support extensible boolean enum: Azure/typespec-azure#1162 - Current TypeSpec doesn't seem to have literals other than string, number and boolean(I can't make object literals work): microsoft#2359 ## About this PR's commits - **TypeSpec code(main purpose)**: 29841a7 - TypeSpec test case in d37d396 - Swagger test case in autorest.java Azure/autorest.java#2953 - Swagger serialization fix: e8454cf - script change for build: 54af0f1 - A minor mapper bug fix: 41673da --------- Co-authored-by: Weidong Xu <weidxu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous non-string expandable enum implementation
After this PR
Limitations
About this PR's commits