Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expression defined in alias doesn't have namespace assigned #4146

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Fix expression defined in alias doesn't have namespace assigned #4146

merged 2 commits into from
Aug 12, 2024

Conversation

timotheeguerin
Copy link
Member

fix #3438

@microsoft-github-policy-service microsoft-github-policy-service bot added the compiler:core Issues for @typespec/compiler label Aug 12, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 12, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
Show changes

@typespec/compiler - fix ✏️

Fix model expression defined in alias will resolve its namespace from the namespace where the alias was declared

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Aug 12, 2024
Merged via the queue into microsoft:main with commit 88d22b0 Aug 12, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/alias-expr branch August 12, 2024 22:26
sarangan12 pushed a commit to sarangan12/typespec that referenced this pull request Sep 16, 2024
@timotheeguerin @sarangan12
Fix expression defined in alias doesn't have namespace assigned (micr…
9255c52 
…osoft#4146)

fix [microsoft#3438](microsoft#3438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
compiler:core Issues for @typespec/compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using alias and referencing models reports versioning errors
3 participants
@timotheeguerin @azure-sdk @markcowl