openapi3 - fixes bug with circular references in unions #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisradek
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
timotheeguerin
approved these changes
Jul 19, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
) Fixes regression introduced in #3908 where docs set at the union level were being applied to each union variant. Co-authored-by: Christopher Radek <Christopher.Radek@microsoft.com>
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3811
Root cause seemed to be that when encountering 2+ non-null items in a union, placeholders weren't getting wrapped by ObjectBuilder and thus the emitter wasn't resolving circular references correctly.