Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versioning issue when @added is used implicitly and explicitly #3255

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Fix versioning issue when @added is used implicitly and explicitly #3255

merged 4 commits into from
Jun 4, 2024

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Apr 30, 2024 •
edited
Loading

Fixes: #3239

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 30, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/versioning
Show changes

@typespec/versioning - fix ✏️

If a property were marked with @added on a later version, the logic that said it was originally added on the first version was erroneously removed, resulting in incorrect projections.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3255/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3255/

@tjprescott tjprescott force-pushed the versioning/FixVersioningBugs branch from 1a65d3f to a8fcbf1 Compare May 8, 2024 16:50
@bterlson bterlson added breaking-change A change that might cause specs or code to break lib:versioning and removed breaking-change A change that might cause specs or code to break labels May 10, 2024
@tjprescott tjprescott force-pushed the versioning/FixVersioningBugs branch 4 times, most recently from e4fbc95 to 92bb935 Compare May 22, 2024 20:29
@tjprescott tjprescott marked this pull request as ready for review May 22, 2024 20:30
@tjprescott tjprescott changed the title Fix versioning bugs Fix versioning issue when @added is used implicitly and explicitly May 22, 2024
@tjprescott tjprescott force-pushed the versioning/FixVersioningBugs branch 2 times, most recently from 92bb935 to c2bd45a Compare May 22, 2024 20:37
@tjprescott tjprescott force-pushed the versioning/FixVersioningBugs branch 3 times, most recently from 6b41a76 to b0591dd Compare May 28, 2024 19:49
@tjprescott tjprescott force-pushed the versioning/FixVersioningBugs branch from b0591dd to 40a77ef Compare June 4, 2024 17:17
@tjprescott tjprescott force-pushed the versioning/FixVersioningBugs branch from 9363c38 to 82f5376 Compare June 4, 2024 18:42
@tjprescott tjprescott added this pull request to the merge queue Jun 4, 2024
Merged via the queue into microsoft:main with commit deedcbb Jun 4, 2024
21 checks passed
@tjprescott tjprescott deleted the versioning/FixVersioningBugs branch June 4, 2024 21:02
This was referenced Jul 5, 2024
Closed
Merged
Merged
Merged
This was referenced Jul 20, 2024
Open
Merged
Merged
This was referenced Jul 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
lib:versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Property is lost in projected versions
4 participants
@tjprescott @azure-sdk @timotheeguerin @bterlson