Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch decoratorArgMarshalling flags to new system by default #4138

Closed
timotheeguerin opened this issue Aug 9, 2024 · 1 comment · Fixed by #4500
Closed

Switch decoratorArgMarshalling flags to new system by default #4138

timotheeguerin opened this issue Aug 9, 2024 · 1 comment · Fixed by #4500
Assignees
@timotheeguerin
Labels
breaking-change A change that might cause specs or code to break compiler:core Issues for @typespec/compiler triaged:core
Milestone
[2024] October

Comments

@timotheeguerin
Copy link
Member

2nd part of the migration

Currently it emit a warning if you use the new value world in your decorator but don't have the $flags decoratorArgMarshalling set to new

We should update that to be the new default and remove that warning.

This change was done in typespec compiler 0.57.0 already 3 release ago. Libraries should have had time to update and at least set the flag to legacy if they meant to keep it working.

Optionally it should emit a warning that the legacy option is deprecated and will be removed soon(3rd stage)
@timotheeguerin timotheeguerin added the breaking-change A change that might cause specs or code to break label Aug 9, 2024
@markcowl markcowl added triaged:core compiler:core Issues for @typespec/compiler labels Aug 12, 2024
@markcowl
Copy link
Contributor

est: 1

@markcowl markcowl added this to the [2024] October milestone Aug 12, 2024
@timotheeguerin timotheeguerin self-assigned this Sep 23, 2024
@timotheeguerin timotheeguerin mentioned this issue Sep 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 5, 2024
@timotheeguerin
Update decorator arg marshalling to new default (#4500)
aa189c6 
fix [#4138](#4138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
breaking-change A change that might cause specs or code to break compiler:core Issues for @typespec/compiler triaged:core
Projects
None yet
Milestone
[2024] October
Development

Successfully merging a pull request may close this issue.

Update decorator arg marshalling to new default timotheeguerin/typespec
2 participants
@timotheeguerin @markcowl