Do we still need `@knownValues` now that we can do union with string option? #3009

timotheeguerin · 2024-03-08T23:42:02Z

We kept it as it was a way to define a set of known values for a string when azure was just using enum and fixed but now that we can use named union with a string option and name values this feels just more verbose with no benefit

fix #3009 --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

microsoft-github-policy-service bot added the needs-area label Mar 8, 2024

markcowl added this to the [2024] April milestone Mar 11, 2024

markcowl added deprecation A previously supported feature will now report a warning and eventually be removed triaged:core and removed needs-area labels Mar 11, 2024

timotheeguerin self-assigned this Apr 2, 2024

timotheeguerin mentioned this issue Apr 2, 2024

Deprecate known values #3094

Merged

timotheeguerin closed this as completed in #3094 Apr 2, 2024

timotheeguerin added a commit that referenced this issue Apr 2, 2024

Deprecate known values (#3094)

63cb176

fix #3009 --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do we still need `@knownValues` now that we can do union with string option? #3009

Do we still need `@knownValues` now that we can do union with string option? #3009

timotheeguerin commented Mar 8, 2024 •

edited

Loading

Do we still need @knownValues now that we can do union with string option? #3009

Do we still need @knownValues now that we can do union with string option? #3009

Comments

timotheeguerin commented Mar 8, 2024 • edited Loading

Do we still need `@knownValues` now that we can do union with string option? #3009

Do we still need `@knownValues` now that we can do union with string option? #3009

timotheeguerin commented Mar 8, 2024 •

edited

Loading